Skip to content

Check for URL and return error if invalid#58

Open
JeffHCross wants to merge 1 commit intosportsdataverse:mainfrom
JeffHCross:main
Open

Check for URL and return error if invalid#58
JeffHCross wants to merge 1 commit intosportsdataverse:mainfrom
JeffHCross:main

Conversation

@JeffHCross
Copy link
Copy Markdown

@JeffHCross JeffHCross commented Feb 17, 2023

Resolves #13
Checks for invalid URLs in sportsdataverse.cfb.load_cfb_schedule and sportsdataverse.cfb.load_cfb_pbp, raising SeasonNotFoundError if the URL is not valid

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sportsdataverse-py ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 6:58PM (UTC)

@JeffHCross
Copy link
Copy Markdown
Author

JeffHCross commented Feb 17, 2023

I didn't notice how sportsdataverse.cfb.load_cfb_team_info handles Exceptions until after I had written valid_url, so hopefully you don't mind the different approach.

@JeffHCross JeffHCross changed the title Resolves #13 -- check for URL and return error if invalid Check for URL and return error if invalid Feb 17, 2023
@armstjc armstjc requested a review from saiemgilani February 18, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 error in games

1 participant