Skip to content

Switch back to type-safe action bindings #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vampire wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch back to type-safe action bindings #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/branches-and-prs.main.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

import io.github.typesafegithub.workflows.actions.actions.Checkout
import io.github.typesafegithub.workflows.actions.actions.Checkout.FetchDepth
import io.github.typesafegithub.workflows.actions.codecov.CodecovAction_Untyped
import io.github.typesafegithub.workflows.actions.codecov.CodecovAction
import io.github.typesafegithub.workflows.actions.testlensapp.SetupTestlens
import io.github.typesafegithub.workflows.domain.Concurrency
import io.github.typesafegithub.workflows.domain.RunnerType
Expand Down Expand Up @@ -134,8 +134,8 @@ workflow(
)
uses(
name = "Upload to Codecov.io",
action = CodecovAction_Untyped(
failCiIfError_Untyped = "true"
action = CodecovAction(
failCiIfError = true
)
)
}
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/codeql-analysis.main.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@

@file:Repository("https://bindings.krzeminski.it/")
@file:DependsOn("actions:checkout___major:[v6,v7-alpha)")
@file:DependsOn("github:codeql-action__analyze___major:[v4.32.4,v5-alpha)")
@file:DependsOn("github:codeql-action__init___major:[v4.32.4,v5-alpha)")
@file:DependsOn("github:codeql-action__analyze___major:[v4,v5-alpha)")
@file:DependsOn("github:codeql-action__init___major:[v4,v5-alpha)")

import io.github.typesafegithub.workflows.actions.actions.Checkout
import io.github.typesafegithub.workflows.actions.github.CodeqlActionAnalyze_Untyped
import io.github.typesafegithub.workflows.actions.github.CodeqlActionInit_Untyped
import io.github.typesafegithub.workflows.actions.github.CodeqlActionAnalyze
import io.github.typesafegithub.workflows.actions.github.CodeqlActionInit
import io.github.typesafegithub.workflows.domain.Concurrency
import io.github.typesafegithub.workflows.domain.RunnerType.UbuntuLatest
import io.github.typesafegithub.workflows.domain.triggers.*
Expand Down Expand Up @@ -85,7 +85,7 @@ workflow(
// Initializes the CodeQL tools for scanning
uses(
name = "Initialize CodeQL",
action = CodeqlActionInit_Untyped(
action = CodeqlActionInit(
// Override language selection by uncommenting this and choosing your languages
// languages = listOf("go", "javascript", "csharp", "python", "cpp", "java"),
)
Expand Down Expand Up @@ -127,7 +127,7 @@ workflow(
)
uses(
name = "Perform CodeQL Analysis",
action = CodeqlActionAnalyze_Untyped()
action = CodeqlActionAnalyze()
)
}
}
6 changes: 3 additions & 3 deletions .github/workflows/release.main.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

import io.github.typesafegithub.workflows.actions.actions.Checkout
import io.github.typesafegithub.workflows.actions.actions.Checkout.FetchDepth
import io.github.typesafegithub.workflows.actions.codecov.CodecovAction_Untyped
import io.github.typesafegithub.workflows.actions.codecov.CodecovAction
import io.github.typesafegithub.workflows.domain.RunnerType
import io.github.typesafegithub.workflows.domain.triggers.Push
import io.github.typesafegithub.workflows.dsl.expressions.Contexts.github
Expand Down Expand Up @@ -103,8 +103,8 @@ workflow(
)
uses(
name = "Upload to Codecov.io",
action = CodecovAction_Untyped(
failCiIfError_Untyped = "true"
action = CodecovAction(
failCiIfError = true
Comment on lines +106 to +107
Copy link

@coderabbitai coderabbitai bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Regenerate the workflow YAML to keep source and runtime workflow in sync.

Lines 106-107 migrated to typed failCiIfError = true, but .github/workflows/release.yaml (Lines 43-46) still reflects the old serialized form. Please regenerate and commit the YAML so the executable workflow matches this Kotlin DSL change.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/release.main.kts around lines 106 - 107, Regenerate and
commit the generated workflow YAML so it matches the Kotlin DSL change: update
the serialized workflow produced from release.main.kts (where CodecovAction now
uses the typed property failCiIfError = true) by re-running the generator/build
step that emits .github/workflows/release.yaml, verify the CodecovAction
configuration in the generated release.yaml reflects failCiIfError: true
(instead of the old serialized form), and commit the updated release.yaml
alongside the DSL change.

)
)
}
Expand Down
Loading