intersphinx: Stringify error arguments in _display_failures#14414
Open
cobaltt7 wants to merge 2 commits intosphinx-doc:masterfrom
Open
intersphinx: Stringify error arguments in _display_failures#14414cobaltt7 wants to merge 2 commits intosphinx-doc:masterfrom
_display_failures#14414cobaltt7 wants to merge 2 commits intosphinx-doc:masterfrom
Conversation
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I got this error when running
sphinx-build:It looks like something threw this error:
And
err.argswas(22, "Invalid argument"). When it was passed to_display_failures, it failed to generate a proper error string.I'm still investigating the cause of the OSError, but for now1 Sphinx should be fixed to propagate the error message properly.I didn't add a changelog entry because it's still the 9.1.0 changelog - should I be the one to update it, or should I wait for someone else?
Docutils 0.22 on py312 and ty typecheck were both failing on main already.
Docutils failure on py315 doesn't seem to be my fault either - it's fixed in #14399
References
https://github.com/psf/black/actions/runs/22561832229/job/65349935011 - CI log that first alerted me to the error
Full traceback
Footnotes
An
intersphinx_mappingkey had</>in it. When Sphinx tried to use it as part of a cache file name, it crashed on Windows, which doesn't allow them in file names. This is more user error than Sphinx's fault, but it should have a clearer error message. ↩