Skip to content

Bump sourcelink - #577

Open
JR-Morgan wants to merge 3 commits into
mainfrom
jrm/bump-sourcelink
Open

Bump sourcelink#577
JR-Morgan wants to merge 3 commits into
mainfrom
jrm/bump-sourcelink

Conversation

@JR-Morgan

Copy link
Copy Markdown
Member

@JR-Morgan
JR-Morgan requested a review from danielgak September 9, 2026 21:24
@JR-Morgan
JR-Morgan enabled auto-merge (squash) September 9, 2026 21:27
@JR-Morgan
JR-Morgan marked this pull request as draft September 9, 2026 21:29
auto-merge was automatically disabled September 9, 2026 21:29

Pull request was converted to draft

@JR-Morgan JR-Morgan closed this Sep 9, 2026
@JR-Morgan

JR-Morgan commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

sourcelink 10 requires a bump of system.memory.
Since we need to keep on an ancient version of system.memory to keep revit happy, I think I'll supress the vulnerability
I don't think we need to reference it directly in order to actually get source link since it's now built into the .NET SDK

@JR-Morgan JR-Morgan reopened this Sep 9, 2026
@JR-Morgan

Copy link
Copy Markdown
Member Author

Source link seems to be ok without directly referencing the nuget. So we can let .NET SDK control the source link version.
image

@JR-Morgan
JR-Morgan marked this pull request as ready for review September 9, 2026 21:44
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.13%. Comparing base (52d45fb) to head (488ca2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   72.13%   72.13%   -0.01%     
==========================================
  Files         473      473              
  Lines       26981    26981              
  Branches     2717     2717              
==========================================
- Hits        19464    19463       -1     
  Misses       6563     6563              
- Partials      954      955       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants