Update tag handling and clean up Builder API#660
Open
WilliamJamieson wants to merge 3 commits intospacetelescope:mainfrom
Open
Update tag handling and clean up Builder API#660WilliamJamieson wants to merge 3 commits intospacetelescope:mainfrom
tag handling and clean up Builder API#660WilliamJamieson wants to merge 3 commits intospacetelescope:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 97.56% 95.33% -2.23%
==========================================
Files 30 27 -3
Lines 2788 2785 -3
==========================================
- Hits 2720 2655 -65
- Misses 68 130 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
753ef05 to
9c75ec6
Compare
Contributor
Author
|
Regression tests pass: https://github.com/spacetelescope/RegressionTests/actions/runs/25167042077/job/73775874639 |
9c75ec6 to
a2e7839
Compare
…_tag by _create_* and the converters
a2e7839 to
7e6009d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been something about how stnode objects handle the setting and removal of the tags that ASDF (or users) can attach to nodes that has been bothering me for a long time, see
roman_datamodels/src/roman_datamodels/_stnode/_converters.py
Line 69 in 649c8eb
This PR attempts to resolve this by adding a constructor to the nodes that takes care of this issue. This in turn means that all the code of the form
could be rolled together. Note that while fixing this issue I noticed/found some small issues with the
Builder/create_*API that could be improved. This PR resolves both the_read_tagand builder API stuff.Tasks
roman_datamodelstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change