Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 95.58% 95.30% -0.28%
==========================================
Files 20 19 -1
Lines 2242 2194 -48
==========================================
- Hits 2143 2091 -52
- Misses 99 103 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4780ae6 to
b25d93f
Compare
There was a problem hiding this comment.
Pull request overview
This PR completes the removal of TICA cube/cutout support from Astrocut (previously deprecated in 1.1.0), simplifying the TESS cube/cutout pipeline to SPOC-only behavior and updating tests/docs accordingly.
Changes:
- Removed
TicaCubeFactoryand eliminated the deprecatedproductparameter across TESS cutout entry points. - Updated core cube-cutout logic to assume SPOC-style cubes include both FLUX and uncertainty planes.
- Refactored/updated tests and helpers to generate SPOC-only fixtures and expectations.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
tox.ini |
Updates flake8 ignores to include W503. |
astrocut/tica_cube_factory.py |
Removes the deprecated TicaCubeFactory implementation. |
astrocut/__init__.py |
Stops exporting TicaCubeFactory from the package top-level. |
astrocut/cutout_factory.py |
Removes deprecated product arg from cube_cut/CutoutFactory.cube_cut wrappers. |
astrocut/cube_cutout.py |
Removes optional-uncertainty handling and assumes a 2-plane cube for cutouts. |
astrocut/tess_cube_cutout.py |
Drops product handling; hardcodes SPOC header/column expectations. |
astrocut/tess_footprint_cutout.py |
Drops deprecated product arg and SPOC-only enforcement logic tied to it. |
astrocut/tests/utils_for_test.py |
Removes TICA test FITS generation and SPOC/TICA branching. |
astrocut/tests/test_tess_footprint_cutout.py |
Removes invalid-product tests and normalizes to SPOC-only expectations. |
astrocut/tests/test_tess_cube_cutout.py |
Removes TICA parametrization and updates expectations to SPOC-only. |
astrocut/tests/test_fits_cutout.py |
Removes SPOC/TICA parametrized fixtures; uses SPOC-only images. |
astrocut/tests/test_cutouts.py |
Removes SPOC/TICA parametrization for image/FITS cutout tests. |
astrocut/tests/test_cutout_processing.py |
Removes SPOC/TICA parametrization where only SPOC is supported. |
astrocut/tests/test_cube_factory.py |
Updates cube factory tests to use CubeFactory and 2-plane expectations. |
astrocut/tests/test_cube_cut.py |
Removes TICA branching and updates expectations to require uncertainty plane. |
CHANGES.rst |
Documents breaking changes for TICA removal and product arg removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4186239 to
87a9809
Compare
|
Actually, since so many of these changes are style, I'm gonna leave this in draft and make another PR to make all the style changes at once. |
87a9809 to
8bdf3cb
Compare
8bdf3cb to
d993436
Compare
Fully removing TICA cubes and cutouts from Astrocut after we deprecated in 1.1.0.