Skip to content

Remove TICA fully#162

Closed
snbianco wants to merge 0 commit intomainfrom
remove-tica-full
Closed

Remove TICA fully#162
snbianco wants to merge 0 commit intomainfrom
remove-tica-full

Conversation

@snbianco
Copy link
Copy Markdown
Collaborator

@snbianco snbianco commented Aug 14, 2025

Fully removing TICA cubes and cutouts from Astrocut after we deprecated in 1.1.0.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 95.79832% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.30%. Comparing base (8c6fbd7) to head (87a9809).

Files with missing lines Patch % Lines
astrocut/cube_cutout.py 90.00% 4 Missing ⚠️
astrocut/tess_cube_cutout.py 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   95.58%   95.30%   -0.28%     
==========================================
  Files          20       19       -1     
  Lines        2242     2194      -48     
==========================================
- Hits         2143     2091      -52     
- Misses         99      103       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snbianco snbianco marked this pull request as ready for review April 28, 2026 19:58
@snbianco snbianco requested a review from Copilot April 28, 2026 20:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the removal of TICA cube/cutout support from Astrocut (previously deprecated in 1.1.0), simplifying the TESS cube/cutout pipeline to SPOC-only behavior and updating tests/docs accordingly.

Changes:

  • Removed TicaCubeFactory and eliminated the deprecated product parameter across TESS cutout entry points.
  • Updated core cube-cutout logic to assume SPOC-style cubes include both FLUX and uncertainty planes.
  • Refactored/updated tests and helpers to generate SPOC-only fixtures and expectations.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tox.ini Updates flake8 ignores to include W503.
astrocut/tica_cube_factory.py Removes the deprecated TicaCubeFactory implementation.
astrocut/__init__.py Stops exporting TicaCubeFactory from the package top-level.
astrocut/cutout_factory.py Removes deprecated product arg from cube_cut/CutoutFactory.cube_cut wrappers.
astrocut/cube_cutout.py Removes optional-uncertainty handling and assumes a 2-plane cube for cutouts.
astrocut/tess_cube_cutout.py Drops product handling; hardcodes SPOC header/column expectations.
astrocut/tess_footprint_cutout.py Drops deprecated product arg and SPOC-only enforcement logic tied to it.
astrocut/tests/utils_for_test.py Removes TICA test FITS generation and SPOC/TICA branching.
astrocut/tests/test_tess_footprint_cutout.py Removes invalid-product tests and normalizes to SPOC-only expectations.
astrocut/tests/test_tess_cube_cutout.py Removes TICA parametrization and updates expectations to SPOC-only.
astrocut/tests/test_fits_cutout.py Removes SPOC/TICA parametrized fixtures; uses SPOC-only images.
astrocut/tests/test_cutouts.py Removes SPOC/TICA parametrization for image/FITS cutout tests.
astrocut/tests/test_cutout_processing.py Removes SPOC/TICA parametrization where only SPOC is supported.
astrocut/tests/test_cube_factory.py Updates cube factory tests to use CubeFactory and 2-plane expectations.
astrocut/tests/test_cube_cut.py Removes TICA branching and updates expectations to require uncertainty plane.
CHANGES.rst Documents breaking changes for TICA removal and product arg removal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread astrocut/cube_cutout.py Outdated
Comment thread astrocut/tess_cube_cutout.py Outdated
Comment thread astrocut/tests/test_tess_footprint_cutout.py
Comment thread astrocut/tests/test_tess_footprint_cutout.py
Comment thread astrocut/cube_cutout.py
Comment thread CHANGES.rst Outdated
Comment thread astrocut/cube_cutout.py
@snbianco snbianco changed the title Remove tica full Remove TICA fully Apr 29, 2026
@snbianco snbianco requested a review from falkben April 29, 2026 13:48
@snbianco snbianco marked this pull request as draft April 29, 2026 14:17
@snbianco
Copy link
Copy Markdown
Collaborator Author

Actually, since so many of these changes are style, I'm gonna leave this in draft and make another PR to make all the style changes at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants