fix: proposed fix for competing UI on mobile - #17
Conversation
|
|
|
Thanks! I'll check this once I find time 👍 |
|
i still remember about this PR, just have to find time, sorry for a long time to review |
|
yeah no worries, take your time my man |
|
you will need to fix the merge conflicts though. can't review the PR until those are solved |
|
resolved the merge conflicts, let me know 😄 |
|
should've fixed the CI issues, my bad |
just tested the thing, the minimap seems too small in height. maybe make it so it expands to full screen when Guess is clicked?
|
|
hold up thats strange hahaha, i had replaced the thing with a button that switched the google map screen with the map but it looks like its gone, ill take a look asap |
|
yeah looks like i messed up the merge, gimme a sec i'll re apply the fix on the latest version, 5 minutes and i'll commit |
|
no rush, take your time |
…nd functionality - Updated button labels in MinimapPanel from 'Open map to place guess' to 'Open map' for clarity. - Adjusted test cases in MinimapPanel.test.tsx to reflect the new button labels and ensure accurate functionality. - Removed unused refs and simplified state management in MinimapPanel for better performance.
|
should be fixed, let me know :D |
Screen.Recording.2026-07-02.at.00.30.52.movLooks much better than what we have right now in prod, but would you mind fixing this bug where zoom level resets every time you close the map? |
|
yeah gimme a sec |
|
did it |
|
bug is still there. please attach a video demonstration in the follow up comment |
Screen-Recording.mp4ignore streetview not showing anything ( i didnt setup the keys) |
|
doesn't seem to be the case on my side. resets just like before on commit 844f525 |
|
thats strange... check line 247 on the MinimapPanel.tsx file, does it have : 'hidden' ? |
|
yes I'm on latest commit of your branch |
|
i swear i'm not understanding how this is happening hahaha, i guess you alr tried hard reloading right? |
|
i'll try another fix, gimme a sec |
|
same issue unfortunately. I can reimplement this feature myself in another commit + credit you as a coauthor in it if you'd like. |
|
yeah it's fine |
3 participants
Improves mobile gameplay by replacing the cramped bottom minimap strip with a full-screen Street View / map toggle.
On viewports under 768px, Street View now uses the full screen by default. A floating Guess button (bottom-right) opens a full-screen map overlay for pin placement; Back returns to Street View. The existing Place Pin / Guess / Waiting finalize flow is unchanged. Desktop keeps the hover-to-expand bottom-right minimap.
What changed:
MinimapPanel — Mobile uses a two-state mapViewOpen toggle instead of tap-to-expand partial minimap, backdrop collapse, and the 80px right gutter. Map overlay sits at z-30 (below HUD at z-40). New optional roundKey prop resets to Street View when the round changes.
InGameScene — Passes roundKey={streetViewSrc} so each new round starts in Street View.
MinimapPanel.test.tsx — Tests for mobile toggle, round reset, and unchanged desktop behavior.