-
Notifications
You must be signed in to change notification settings - Fork 193
Versioning and history #3659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nocaxe
wants to merge
20
commits into
source-academy:master
Choose a base branch
from
Nocaxe:Versioning-and-History
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,614
−96
Open
Versioning and history #3659
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
998523d
Implement Versioning and History of Editor Code for Assessment Worksp…
Nocaxe ef29046
Create tests for versioning and history feature
Nocaxe fae8626
Prevent submit answer from displaying success message, as submit stat…
Nocaxe 9de2544
Fix updateVersionName API route and getVersionHistory return value
Nocaxe 30b0d51
Fix bug causing double saving, now only submits answer, and allows th…
Nocaxe de8311a
Change restored versions to be named "(name)-restored" instead of "(t…
Nocaxe d35c2fe
Prevent autosave in team assessments
Nocaxe 2fc355b
Implement UI for Versioning and History feature
Nocaxe bd20063
Implement version preview before restoring
Nocaxe de13c58
Fix bug causing duplicate versions to be saved
Nocaxe c9367d6
Prevent save status indicator from showing in team assessments
Nocaxe ed49c48
Update test to not check for success message upon autosave
Nocaxe 0635aae
Update snapshots to align with changes
Nocaxe bc361e3
Reformatted imports
Nocaxe 13849ea
Fix bug where save status is not correctly checked and updated, alway…
Nocaxe 784c395
Refactor restoreVersionSaga and prevent restoring from auto-submittin…
Nocaxe f504c5c
Fix bug where renaming updates the timestamp
Nocaxe cebe414
Fix bug where restoring was renaming the wrong version
Nocaxe 1714803
Merge branch 'master' into Versioning-and-History
martin-henz 78129b8
Merge branch 'master' into Versioning-and-History
Nocaxe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the save button for team assessments has been unintentionally removed from the mobile view. The
editorButtonsarray for mobile only contains theresetButton. For team assessments, where auto-save is disabled, the manual save button is still required. TheversionHistoryButtonandsaveStatusIndicatorshould also likely be available on mobile.I suggest including these buttons in the mobile view. React will filter out any
nullbuttons automatically.