Ignore invalid output from docker stats command#334
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Dec 23, 2025
Merged
Ignore invalid output from docker stats command#334qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Junchao-Mellanox <junchao@nvidia.com>
d46b1ad to
d9ba0bc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Junchao-Mellanox <junchao@nvidia.com>
|
/azp run |
qiluo-msft
approved these changes
Dec 23, 2025
Contributor
qiluo-msft
left a comment
There was a problem hiding this comment.
thanks for this bugfix!
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Cherry-pick PR to 202511: #341 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did this
We found some error in syslog:
The error is statistical. The flow is as below:
After reviewing sonic code and docker code, I found that sonic would never generate a data with
NAME=--; while docker might do so. Docker might generate such invalid output in a flow like this:3. other user removes container a
For detailed docker code, please check:
https://github.com/docker/cli/blob/93fa57bbcd08f2f5be7f6cf22f4273a2b5a49e71/cli/command/container/formatter_stats.go#L25
https://github.com/docker/cli/blob/93fa57bbcd08f2f5be7f6cf22f4273a2b5a49e71/cli/command/container/formatter_stats.go#L169
This PR is to fix the issue
How I did this
procdockerstatsd should check the command output and ignore invalid value:
How I test this
Manual test