Open
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Deploying sos25-client with
|
| Latest commit: |
eed243e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://465856dc.sos25-client.pages.dev |
| Branch Preview URL: | https://project-complete-bar.sos25-client.pages.dev |
reversed-R
requested changes
Apr 26, 2025
Contributor
reversed-R
left a comment
reversed-R
left a comment
There was a problem hiding this comment.
LBTMeow...
^ ^
(; ω ;) ) ~
| projectData: components["schemas"]["Project"]; | ||
| mutation: () => void; | ||
| step: 1 | 2 | 3 | 4 | 5; | ||
| step: 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9; |
Contributor
There was a problem hiding this comment.
ステップを全て直列化させているのは流石にエグいかな、と。
例えば、状態をそれぞれが完了しているかのbooleanをもった構造体で表現して、表示する部分でprogress\d.svgに変換したほうがロジックが分かりやすそう
| } | ||
|
|
||
| if (!formIsLoading && formData) { | ||
| let hasAnsweredEveryForm = true; |
Contributor
There was a problem hiding this comment.
全ての申請に答えていなければならないので、もとのほうが正しそう
プレビューで実験したところ1つだけ答えたところで申請提出doneになっていて、正しい挙動でない
誓約書提出フォームを除く全ての申請にしたほうが良い
Contributor
|
@mikio815 どうなってますか？ |
Contributor
Author
今絶妙に手がつけられそうにないです |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
更新して、判定ロジックも少し変えたので色々試してみてください