remove unused val in generated code#635
Merged
adamw merged 3 commits intosoftwaremill:scala2from Mar 16, 2026
Merged
Conversation
Contributor
Author
|
I guess this relates to changes from #628 @nigredo-tori could you also take a look, please? |
nigredo-tori
suggested changes
Mar 13, 2026
nigredo-tori
left a comment
nigredo-tori
left a comment
There was a problem hiding this comment.
LGTM other than the function thing.
nigredo-tori
approved these changes
Mar 14, 2026
| } | ||
|
|
||
| test("construct a Show instance for huge enums") { | ||
| val res = Show.gen[HugeEnum].show(HugeEnum.Case42) |
There was a problem hiding this comment.
Thank you for adding a test for this!
Contributor
Author
|
@adamw Could you please take a look? |
Member
|
@road21 Sure, merged, thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #634