Skip to content

[Simulation] Remove DAGSimulation - #6261

Open
damienmarchal wants to merge 20 commits into
sofa-framework:masterfrom
CRIStAL-PADR:pr-remove-dagsimulation
Open

[Simulation] Remove DAGSimulation#6261
damienmarchal wants to merge 20 commits into
sofa-framework:masterfrom
CRIStAL-PADR:pr-remove-dagsimulation

Conversation

@damienmarchal

@damienmarchal damienmarchal commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Replace all occurrences of DAGSimulation with Simulation in test files and application examples as part of the removal of the deprecated Sofa.Simulation.Graph package.

  • Replace new sofa::simulation::graph::DAGSimulation() with
    new sofa::simulation::Simulation() in all test files
  • Replace DAGNode with Node in sofaProjectExample
  • Update SimpleApi to use Simulation instead of DAGSimulation
  • Remove includes of DAGSimulation.h

Remaining work: remove Sofa.Simulation.Graph package and update CMake dependencies.

[ci-depends-on https://github.com/sofa-framework/SofaGLFW/pull/296]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/635]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/239]
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/181]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/352]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.Inverse/pull/90]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal damienmarchal added pr: breaking Change possibly inducing a compilation error pr: refactoring Refactor code labels Aug 25, 2026
fredroy
fredroy reviewed Aug 26, 2026
View reviewed changes
Comment thread Sofa/framework/Simulation/Graph/src/sofa/simulation/graph/DAGSimulation.h Outdated
@alxbilger alxbilger changed the title Remove DAGSimulation [Simulation] Remove DAGSimulation Aug 26, 2026
@damienmarchal
Remove DAGSimulation usage, replace with Simulation
e80bc30 
Replace all occurrences of DAGSimulation with Simulation in test files
and application examples as part of the removal of the deprecated
Sofa.Simulation.Graph package.

- Replace new sofa::simulation::graph::DAGSimulation() with
  new sofa::simulation::Simulation() in all test files
- Replace DAGNode with Node in sofaProjectExample
- Update SimpleApi to use Simulation instead of DAGSimulation
- Remove includes of DAGSimulation.h

Remaining work: remove Sofa.Simulation.Graph package and update CMake dependencies.
@damienmarchal
Add deprecation layer.
5a5b77d
This was referenced Aug 26, 2026
Open
Open
Open
Open
Open
@damienmarchal damienmarchal added the pr: status to review To notify reviewers to review this pull-request label Aug 26, 2026
@sofabot

sofabot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

This was referenced Aug 26, 2026
Closed
Open
@sofabot

sofabot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

@damienmarchal

damienmarchal commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

[ci-build][with-scene-tests][with-regression-tests]

@sofabot

sofabot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #10.

To unlock the merge button, you must

@damienmarchal
damienmarchal force-pushed the pr-remove-dagsimulation branch from 5b5d721 to 94f5b73 Compare August 27, 2026 12:56
@sofabot

sofabot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #11.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #12.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #13.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #14.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #15.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #16.

To unlock the merge button, you must

@fredroy

fredroy commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

This PR can only be merged by someone (I guess only @sofa-framework/consortium-staff ) who can merge all the dependent PRs at once

fredroy
fredroy requested changes Sep 9, 2026
View reviewed changes
Comment thread Sofa/framework/Simulation/Graph/src/sofa/simulation/graph/DAGSimulation.h Outdated

namespace sofa::simulation::graph
{
using DAGSimulation=Simulation;

@fredroy fredroy Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the [[deprecated]] / SOFA_ATTRIBUTE_DEPRECATED
stuff for lifecycle

like:

sofa/Sofa/Component/Engine/Generate/compat/sofa/component/engine/generate/VolumeFromTetrahedrons.h

Line 30 in cfa5252

using VolumeFromTetrahedrons SOFA_ATTRIBUTE_DEPRECATED__VOLUMEFROMTETRAHEDRONS() = VolumeFromVolumetricElements<DataTypes>;

@sofabot

sofabot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #17.

To unlock the merge button, you must

@damienmarchal damienmarchal removed the pr: status to review To notify reviewers to review this pull-request label Sep 9, 2026
@damienmarchal
damienmarchal force-pushed the pr-remove-dagsimulation branch from 02b2913 to 5bffa92 Compare September 9, 2026 09:20
@sofabot

sofabot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #18.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #19.

To unlock the merge button, you must

fredroy and others added 10 commits September 9, 2026 11:29
@fredroy @bakpaul @damienmarchal
[Type] UnitTest: use EXPECT_DOUBLE_EQ as advised for Matrix:trace() t…
637c408 
…est (sofa-framework#6267)

use EXPECT_DOUBLE_EQ as advised

Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
@fredroy @bakpaul @damienmarchal
[LinearAlgebra] Unittests: increase the epsilon for tests with Sparse…
0180fc8 
…Matrix (sofa-framework#6268)

* use EXPECT_DOUBLE_EQ as advised

* increase epsilon in eq testing with zero

---------

Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
@update-pixi-lockfile @olivier-roussel
@bakpaul @damienmarchal
[CI] Update pixi lockfile (sofa-framework#6285)
9142f18 
pixi: Update pixi lockfile

Co-authored-by: olivier-roussel <2340432+olivier-roussel@users.noreply.github.com>
Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
@fredroy @damienmarchal
[Sofa.Simulation.Core] MappingGraph: fix memory leak in from parent/c…
8d6f5cd 
…hild shared_ptr cycle (sofa-framework#6259)

MappingGraph: fix memory leak in from parent/child shared_ptr cycle
@alxbilger @damienmarchal
[Playback] Explicit links in ReadState/WriteState (sofa-framework#6277)
f905ecb 
* [Playback] Explicit links in ReadState/WriteState

* adapt code in CompareState
@alxbilger @damienmarchal
[Simulation] Deprecate SceneLoaderPHP (sofa-framework#6265)
67e20fb
@fredroy @alxbilger @damienmarchal
[Type] Mat: Fix invertMatrix self-aliasing bug in Mat2x2/Mat3x3 (sofa…
bd2e7d4 
…-framework#6275)

* demonstate that 2x2 and 3x3 selfaliasing invertmatrix are wrong

* cache value before using/overwriting them

---------

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@th-skam @damienmarchal
[FEM] Implement getPotentialEnergy for Linear & Corotational FEMForce…
79cfe09 
…Field (sofa-framework#6228)

* Add potential energy computation for the LinearSmallStrainFEMForceField

* Add potential energy for the CorotationalFEMForceField

* Use auto

* Factor out displacement compute helper
@fredroy @damienmarchal
[LinearSystem] MatrixProjectionMethod: Fix out-of-bounds matrix writes (
ae23596 
sofa-framework#6256)

Fix out-of-bounds matrix writes in MatrixProjectionMethod
@damienmarchal
Add deprecation layer.
101f2c9
@damienmarchal
damienmarchal force-pushed the pr-remove-dagsimulation branch from 9e2b1e9 to 101f2c9 Compare September 9, 2026 09:30
@sofabot

sofabot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #20.

To unlock the merge button, you must

@damienmarchal damienmarchal added the pr: status to review To notify reviewers to review this pull-request label Sep 9, 2026
@sofabot

sofabot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #21.

To unlock the merge button, you must

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredroy fredroy fredroy requested changes
@alxbilger alxbilger alxbilger approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

pr: breaking Change possibly inducing a compilation error pr: refactoring Refactor code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@damienmarchal @sofabot @fredroy @alxbilger @th-skam