Fix build error with Ruby 3.1 on Windows#112
Merged
ioquatix merged 1 commit intosocketry:mainfrom Oct 3, 2024
Merged
Conversation
Watson1978
force-pushed
the
fix-build-error
branch
from
9bad294 to
9cb12a7
Compare
Member
|
I may need to review the test failures, it may be unrelated to the PR. I'll try to take a look shortly. |
Contributor
Author
|
Thanks |
4 tasks
ioquatix
force-pushed
the
fix-build-error
branch
from
9cb12a7 to
b946479
Compare
Since Ruby 3.2, `pipe` function declaration is provided in https://github.com/ruby/ruby/blob/21c708ee802e1a59901eccc6448e40e8f72189b8/include/ruby/missing.h#L292 However, it does not provided it with Ruby 3.1. This patch will define `pipe` macro to use proper function due to fix build error.
ioquatix
force-pushed
the
fix-build-error
branch
from
b946479 to
e30094a
Compare
Member
|
This is a good start to better windows support. Thanks. |
Member
|
I have released v1.7.0 which works with Windows, tested on Ruby v3.1+. For better compatibility, we should work on #97. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Ruby 3.2,
pipefunction declaration is provided in https://github.com/ruby/ruby/blob/21c708ee802e1a59901eccc6448e40e8f72189b8/include/ruby/missing.h#L292However, it does not provided it with Ruby 3.1.
This patch will define
pipemacro to use proper function due to fix build error.Types of Changes
Fix #111
Contribution