-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New endpoint2 #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
philvarner-snyk
wants to merge
57
commits into
snyk-labs:main
Choose a base branch
from
varner-tech:new-endpoint2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New endpoint2 #1565
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
982c359
Add new line to .gitignore
philvarner-snyk 8e9fed7
Add Snyk security scanning workflow
philvarner-snyk fde3a53
Merge branch 'main' of github.com:Snyk-Integration-App/nodejs-goof
philvarner-snyk 4a75215
test new dockerfile and new github action
philvarner-snyk 7af360b
comment out
philvarner-snyk 5151dd5
remove old ymls
philvarner-snyk b226044
Update upload-artifact to v4 to fix deprecation warning
philvarner-snyk 0dab142
test
philvarner-snyk ecd0183
Fix Snyk scan configuration to properly separate Node.js and Docker s…
philvarner-snyk c5c9cb0
Update workflow to continue on Node.js scan error for Docker scan
philvarner-snyk 546be01
Add Snyk Code scan to workflow
philvarner-snyk fbbfb71
Add Snyk Code scan to workflow
philvarner-snyk 04a42fb
Add Snyk Code scan to workflow
philvarner-snyk a214f6b
new code with vulnerability
philvarner-snyk cb2e5f3
Add Snyk Code scan to workflow
philvarner-snyk 9f57790
feat: make all Snyk scans continue on error for complete results
philvarner-snyk 0e8c078
Merge branch 'main' into new-endpoint
philvarner-snyk 0cdd6e8
test new commit
philvarner-snyk 3d71cca
no longer run the pipeline on pull_request
philvarner-snyk 0a45b30
add terraform file with misconfigurations
philvarner-snyk 47d50ce
Merge branch 'main' into new-endpoint
philvarner-snyk ce28686
update iac test
philvarner-snyk 6852d21
brand new routes
philvarner-snyk 0c44e56
add monitor to scans, remove vulnerable route call
philvarner-snyk 9f0845d
Merge branch 'main' into new-endpoint
philvarner-snyk 540ebd6
Merge pull request #6 from varner-tech/new-endpoint
philvarner-snyk 3d20f00
test a new endpoint
philvarner-snyk 216e4bc
fix bug
philvarner-snyk 3a7015e
fix org
philvarner-snyk d53c832
Merge pull request #9 from varner-tech/new-endpoint
philvarner-snyk ca21ce5
project name
philvarner-snyk f1ff2ae
Merge pull request #10 from varner-tech/new-endpoint
philvarner-snyk 8e3ff66
add file hops for vulnerability
philvarner-snyk e43d8af
update pipeline
philvarner-snyk 9de2a45
test new function path for vulnerability
philvarner-snyk 0fde06f
comment out
philvarner-snyk 8198707
Merge pull request #11 from varner-tech/new-endpoint
philvarner-snyk 1b960be
test
philvarner-snyk 869e261
Merge pull request #12 from varner-tech/new-endpoint
philvarner-snyk 61bbb95
test new name and target for yml
philvarner-snyk c82c151
Merge pull request #13 from varner-tech/new-endpoint
philvarner-snyk 556cf1f
update yml
philvarner-snyk 7f36c89
fix args error
philvarner-snyk 98e6e7b
Test new scan
philvarner-snyk 7d9eb23
new container scan
philvarner-snyk 4c2cd80
go time --report only
philvarner-snyk abf907f
only run iac
philvarner-snyk 5150064
add project name
philvarner-snyk 694e56d
target name
philvarner-snyk 601bac1
test iac with url target
philvarner-snyk 5a8d32a
test
philvarner-snyk 70e254f
restore full yml for gh actions
philvarner-snyk 81bc269
simplify yml
philvarner-snyk ced38a8
remove SCA and SAST
philvarner-snyk 0b76cf2
rename action
philvarner-snyk f49c80f
add back the bad endpoint
philvarner-snyk 2f7cf56
comment out the function
philvarner-snyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| name: Snyk Security Scan | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main, master ] | ||
| # pull_request: | ||
| # branches: [ main, master ] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| security-scan: | ||
| name: Snyk IaC and Container Scans | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| SNYK_CFG_ORG: varner-tech-engineering | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Install Terraform | ||
| uses: hashicorp/setup-terraform@v2 | ||
| with: | ||
| terraform_version: 1.5.0 | ||
|
|
||
| - name: Install Snyk CLI | ||
| run: npm install -g snyk | ||
|
|
||
| - name: Build Container Image | ||
| run: docker build -t nodejs-goof . | ||
|
|
||
| - name: Snyk Container Scan (test + monitor) | ||
| continue-on-error: true | ||
| run: | | ||
| snyk container test nodejs-goof --severity-threshold=high --file=Dockerfile --project-name=ga-container-full --target-reference=nodejs-goof-ga-target --target-name=nodejs-goof || true | ||
| snyk container monitor nodejs-goof --file=Dockerfile --project-name=ga-container-full --target-reference=nodejs-goof-ga-target --target-name=nodejs-goof | ||
|
|
||
| - name: Snyk IaC Scan | ||
| continue-on-error: true | ||
| run: snyk iac test vulnerable.tf --report --target-name=nodejs-goof --target-reference=nodejs-goof-ga-target --remote-repo-url=https://github.com/varner-tech/nodejs-goof | ||
|
|
||
| - name: Upload Snyk results as artifact | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: snyk-results | ||
| path: snyk*.json | ||
| if-no-files-found: ignore |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Session cookie name contains trailing space
The session cookie name is set to
'connect.sid 'with a trailing space. This could cause session handling issues since cookie names with trailing whitespace may be handled inconsistently across browsers and servers, potentially breaking session persistence or causing authentication problems.