Conversation
Signed-off-by: Soumyadeep Ghosh <soumyadeepghosh2004@zohomail.in>
There was a problem hiding this comment.
Pull request overview
This PR enables binary stripping across multiple parts in the ffmpeg-2404-sdk snapcraft configuration to reduce the final snap size. The changes also include simplifying the libdovi build process and adding --disable-static to zimg.
Changes:
- Add stripping flags to multiple parts (zimg, vulkan-headers, vulkan-loaders, placebo, svt-av1) using appropriate build-system-specific methods
- Remove the rustup part and simplify libdovi build by using the rust plugin directly
- Add --disable-static to zimg and --library-type=cdylib to libdovi to build only dynamic libraries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
brlin-tw
requested changes
Jan 22, 2026
Signed-off-by: Soumyadeep Ghosh <soumyadeepghosh2004@zohomail.in>
Member
Author
|
@brlin-tw I hope the build works now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.