[CRE-4317] Implement EVM ocr3types.OnchainKeyring2#469
Draft
pavel-raykov wants to merge 7 commits into
Draft
Conversation
Contributor
✅ API Diff Results -
|
kaleofduty
reviewed
May 13, 2026
kaleofduty
reviewed
May 13, 2026
kaleofduty
reviewed
May 18, 2026
| // CreateOCR3OnchainKeyring creates a new OCR3 onchain keyring. | ||
| // Note that key names are prefixed with PrefixEVM and PrefixOCR2Onchain (to preserve compatibility with OCR2) | ||
| // For example, a key named "test-key" will be stored at the path "evm/ocr2_onchain/test-key". | ||
| func CreateOCR3OnchainKeyring[RI any](ctx context.Context, ks keystore.Keystore, keyringName string) (ocr3types.OnchainKeyring2[RI], error) { |
Contributor
There was a problem hiding this comment.
I am wondering whether we should (a) specialize this to RI being struct{} to make it more misuse resistant or (b) document the following caveat:
Products may embed safety-critical information affecting signature computation into RI. (E.g. marking reports as "specimen" that must not to be accepted onchain.) If we allow any RI, one could mistakenly use this keyring, but the safety-critical information would be silently discarded.
Contributor
Author
There was a problem hiding this comment.
Currently, for any types A and B we can create OnchainKeyring2[A] with CreateOCR3OnchainKeyring[A], and then read it as OnchainKeyring2[B] with ListOCR3OnchainKeyrings[B]. Do we want to do something to prevent that? If not, I would rather restrict these methods to struct{}.
Comment on lines
+157
to
+158
| // hashReport performs OCR3 report hashing. The main difference from OCR2 hashing (https://github.com/smartcontractkit/chainlink-evm/blob/b4068bf735e6e1af28602eece9e29a0bd31eed37/pkg/keys/v2/ocr2_onchain_keyring.go#L98) | ||
| // is that we hash the sequence number `seqNr` instead of epoch||round (while also changing the hashing order). |
Contributor
There was a problem hiding this comment.
Suggested change
| // hashReport performs OCR3 report hashing. The main difference from OCR2 hashing (https://github.com/smartcontractkit/chainlink-evm/blob/b4068bf735e6e1af28602eece9e29a0bd31eed37/pkg/keys/v2/ocr2_onchain_keyring.go#L98) | |
| // is that we hash the sequence number `seqNr` instead of epoch||round (while also changing the hashing order). | |
| // hashReport computes an EVM-friendly cryptographic hash function over configDigest, seqNr, and reportWithInfo.Report. | |
| // The main difference from OCR2 hashing (https://github.com/smartcontractkit/chainlink-evm/blob/b4068bf735e6e1af28602eece9e29a0bd31eed37/pkg/keys/v2/ocr2_onchain_keyring.go#L98) | |
| // is that we hash the sequence number `seqNr` instead of `epoch||round||extraHash`. | |
| // Domain separation is guaranteed because the result of this function is a Keccak hash computed over 96 bytes | |
| // while the aforementioned OCR2 function is a Keccak hash computed over 128 bytes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.