feat: meshV2: Create broadcast message locally if it doesn't exist when received from mesh#85
Open
takaokouji wants to merge 3 commits intodevelopfrom
Open
feat: meshV2: Create broadcast message locally if it doesn't exist when received from mesh#85takaokouji wants to merge 3 commits intodevelopfrom
takaokouji wants to merge 3 commits intodevelopfrom
Conversation
…en received from mesh - Automatically create broadcast message on the stage when received via meshV2 if it doesn't exist locally. - Ensures the message is selectable in block dropdowns by calling this.runtime.requestBlocksUpdate(). - Uses the newly created or existing broadcast message ID when triggering the broadcast opcode. - Added unit test to verify automatic creation and opcode argument handling. - Updated integration test mock to support new message creation logic. Fixes #84 Co-Authored-By: Gemini <noreply@google.com>
- Added isPersistent property to Variable class. - Modified emitWorkspaceUpdate in virtual-machine.js to skip deletion of broadcast messages marked as persistent. - Set isPersistent = true for messages automatically created from meshV2. - Updated unit test to verify persistence. This ensures messages received from mesh remain selectable in block dropdowns even if they aren't currently used by any block. Fixes #84 Co-Authored-By: Gemini <noreply@google.com>
…casts - Switched from lookupBroadcastMsg to lookupBroadcastByInputValue for initial message lookup to ensure case-insensitivity. - Use the canonical name from the found/created variable when triggering event_broadcast. - Updated mock objects in unit tests. This prevents duplicate broadcast messages and ensures that event handlers are correctly triggered even when message names have different casing. Fixes duplicate message issue and event triggering failure. Co-Authored-By: Gemini <noreply@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements automatic creation of broadcast messages when they are received from the mesh network but do not exist in the local project.
Changes
broadcastEventinMeshV2Serviceto check for message existence on the stage.stage.createVariablewithVariable.BROADCAST_MESSAGE_TYPE.this.runtime.requestBlocksUpdate()is called to ensure the new message appears in block dropdowns immediately.test/unit/mesh_service_v2_broadcast_creation.js.test/unit/mesh_service_v2_integration.jsto support the new logic.Verification Results
npm run tap:unit(Specifically verified the new test file and integration test).npm run lint.Fixes #84