fix: validate group expiration in joinGroup mutation (#25)#26
Merged
takaokouji merged 1 commit intomainfrom Dec 31, 2025
Merged
fix: validate group expiration in joinGroup mutation (#25)#26takaokouji merged 1 commit intomainfrom
takaokouji merged 1 commit intomainfrom
Conversation
- Convert joinGroup to a pipeline resolver using checkGroupExists. - Move joinGroup logic to joinGroupFunction.js. - Add integration test for expiresAt validation. - Update existing tests to expect GroupNotFound error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts joinGroup to a pipeline resolver using checkGroupExists to ensure that users cannot join expired groups.
Changes: