Conversation
|
Please don't start the title with ChangeLog. (otherwise it sounds like the commit touches only the changelog) |
ChangeLog: Bump MSRV to 1.92
|
Done :) |
|
Relevant: (not sure if need to be done in this PR though) The rust-version of the helper crate is not using the workspace and so may block cargo update (I don't know if this is a problem or not) |
ogoffart
left a comment
There was a problem hiding this comment.
Please also update the instance in docs/building.md
|
I've upgraded all the places in the code you mentioned. @expenses Do you remember what you meant with this? // until slint uses rust 1.90 as MSRV.
const fn round(mut value: f32) -> u8 {
if value % 1.0 > 0.5 {
value += 0.5;
}
value as _
} |
https://doc.rust-lang.org/std/primitive.f32.html#method.round f32::round was only made const in 1.90 |
…ions And fix up docs :)
|
Thanks. I've now replaced |
No description provided.