Winit: Implement native popup#11313
Draft
Murmele wants to merge 37 commits intoslint-ui:features/winit-0.31from
Draft
Winit: Implement native popup#11313Murmele wants to merge 37 commits intoslint-ui:features/winit-0.31from
Murmele wants to merge 37 commits intoslint-ui:features/winit-0.31from
Conversation
Murmele
force-pushed
the
mm/features/winit-0.31-popup
branch
from
12d3072 to
04fbb8c
Compare
Reason: Previously always the main window adapter is used for popups as well. This is not correct, because then acting on the wrong renderer caches is done and the application might crash or memory gets not freed. To solve this problem. Showing the popup is split up in multiple steps. 1) Creating the window adapter for the popup if possible. 2) Assigning this window adapter to the popup instance so that the tree will be setup with the newly created window adapter. 3) Determine the popup location and show the created popup
Murmele
force-pushed
the
mm/features/winit-0.31-popup
branch
from
6aa4606 to
bb05f92
Compare
Reason: Because it is required to determine the scaling factor for text
Reason: If the popup size is fixed not the layour constraints must be used
Reason: Otherwise determining if the window should have fixed size or should use the children layout constraints is not possible
Reason: With the changes in 65929d4 the popup has it's own layout constraints and therefore the constraints get projected to the width and height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: