DRAFT: Creating a MenuBar::visible property#11272
Open
npwoods wants to merge 4 commits intoslint-ui:masterfrom
Open
DRAFT: Creating a MenuBar::visible property#11272npwoods wants to merge 4 commits intoslint-ui:masterfrom
MenuBar::visible property#11272npwoods wants to merge 4 commits intoslint-ui:masterfrom
Conversation
This allows a menu bar to be invisible, but also to have menu shortcuts to function properly. This is incomplete; when we're doing menus with the `muda` crate, the `visible` property is not honored
…e to honor it Notes - Documentation added to `menubar.mdx` - Nothing is setting this property yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a menu bar to be invisible, but also to have menu shortcuts to function properly.
This is incomplete; when we're doing menus with the
mudacrate, thevisibleproperty is not honored.For
mudato be supported, it looks like some additional plumbing would have to happen ininternal/core/window.rsassetup_menubar()is passed avtable::VRc<MenuVTable>, and after lowering themenubar-visibleproperty is onMenuBarImpl. While I'm not an expert here, it looks like something more substantial would need to be passed tosetup_menubar()as it is not just necessary to pass the property, but the facilities required to respond to changes.