Add application-side Keys construction support#11271
Draft
amirHdev wants to merge 1 commit intoslint-ui:masterfrom
Draft
Add application-side Keys construction support#11271amirHdev wants to merge 1 commit intoslint-ui:masterfrom
amirHdev wants to merge 1 commit intoslint-ui:masterfrom
Conversation
amirHdev
force-pushed
the
issue-11117-keys-from-app-logic
branch
4 times, most recently
from
a92fefd to
76eaa7f
Compare
amirHdev
force-pushed
the
issue-11117-keys-from-app-logic
branch
from
76eaa7f to
52aba10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add a public constructor path for
Keysvalues from application code and support settingkeysproperties from the Node and Python interpreter APIsThis adds
Keys::from_key_name_or_string(...)plus modifier builder helpers in core and re exports from the Rust API.Node accepts either a string such as
"Escape"or an object such as{ key: "Plus", control: true, ignoreShift: true }when assigning to akeysproperty. python accepts either a string or a dict with the corresponding fields.Tests
cargo test -p i-slint-core test_keys_from_key_name_or_string