Swik 2438 missing thumbnails in import preview#1137
Open
Conversation
Contributor
|
@dpaun please can you resolve conflicts? |
Member
Author
|
Yes, of course. I've resolved conflicts. |
Contributor
|
On testing, no thumbnails appeared (see screenshot). Suggest not merging this for now without more testing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is by no means critical or urgent...
There are sometimes problems with getting thumbnails right after import has been completed (I guess it takes time to create thumbnails on the file service). This PR tries to solve this by retrieving thumbnail files from the file service, repeatedly, 10 times, and using base64 to show these images in a modal dialog.
One way to test it and see whether it's an improvement is by showing both base64 and url (current approach) based images (uncommenting lines 117 and 122 in ImportPreviewModal.js).
There are also some improvements for the import progress bar.