Skip to content

Add wire type metadata and update YAML configurations#24

Merged
kabanaty merged 10 commits intoslaclab:mainfrom
kabanaty:main
Apr 2, 2026
Merged

Add wire type metadata and update YAML configurations#24
kabanaty merged 10 commits intoslaclab:mainfrom
kabanaty:main

Conversation

@kabanaty
Copy link
Copy Markdown
Collaborator

This pull request updates wire metadata and related code to better distinguish between different types of wires, specifically adding "fast" and "slow" type classifications. The changes affect both the code that processes wire data and the YAML configuration files that store wire metadata.

The most important changes are:

Wire Metadata Enhancements:

  • Added a new type field (with values "fast" or "slow") to each wire entry in slac_db/package_data/wire_metadata.yaml and all relevant YAML configuration files, replacing the previous generic "WIRE" type. This allows for more granular classification of wires throughout the system.

Code Updates for New Metadata:

  • Updated the extract_wires method in slac_db/generate.py to include new mappings for MPSSPEED (as mps_speed) and MOTR_SWITCH_ON_CMD (as torque_enable), supporting the extended wire metadata.

These changes standardize wire type information across the codebase and metadata files, enabling clearer differentiation between wire types for downstream processing and analysis.

Copy link
Copy Markdown
Collaborator

@eloise-nebula eloise-nebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type is already a metadata field in all of our device yaml entries. Maybe use wire_type instead.

Comment thread slac_db/yaml/BC2.yaml
Copy link
Copy Markdown
Member

@nneveu nneveu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change 'type' to 'wire_type' (Eloise's comment)
  • check if type name needs to be on new line or not?

Thanks!

Comment thread slac_db/yaml/BC1.yaml
@nneveu
Copy link
Copy Markdown
Member

nneveu commented Apr 1, 2026

@kabanaty @eloise-nebula I think we can skip the lcls-tools test now? @unittest.skip("...note here...")

@eloise-nebula
Copy link
Copy Markdown
Collaborator

@kabanaty @eloise-nebula I think we can skip the lcls-tools test now? @unittest.skip("...note here...")

The test isn't in the main branch right now. Tyler just has to merge.

@nneveu
Copy link
Copy Markdown
Member

nneveu commented Apr 2, 2026

Sorry, I missed that this was the same test from before. Thanks!

@kabanaty kabanaty merged commit 566ad6a into slaclab:main Apr 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants