Add wire type metadata and update YAML configurations#24
Merged
kabanaty merged 10 commits intoslaclab:mainfrom Apr 2, 2026
Merged
Add wire type metadata and update YAML configurations#24kabanaty merged 10 commits intoslaclab:mainfrom
kabanaty merged 10 commits intoslaclab:mainfrom
Conversation
eloise-nebula
requested changes
Mar 25, 2026
Collaborator
eloise-nebula
left a comment
There was a problem hiding this comment.
type is already a metadata field in all of our device yaml entries. Maybe use wire_type instead.
nneveu
approved these changes
Mar 31, 2026
Member
nneveu
left a comment
There was a problem hiding this comment.
- change 'type' to 'wire_type' (Eloise's comment)
- check if type name needs to be on new line or not?
Thanks!
…ne so field instantiates as a string instead of a list.
Member
|
@kabanaty @eloise-nebula I think we can skip the lcls-tools test now? |
Collaborator
The test isn't in the main branch right now. Tyler just has to merge. |
Member
|
Sorry, I missed that this was the same test from before. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates wire metadata and related code to better distinguish between different types of wires, specifically adding "fast" and "slow" type classifications. The changes affect both the code that processes wire data and the YAML configuration files that store wire metadata.
The most important changes are:
Wire Metadata Enhancements:
typefield (with values "fast" or "slow") to each wire entry inslac_db/package_data/wire_metadata.yamland all relevant YAML configuration files, replacing the previous generic "WIRE" type. This allows for more granular classification of wires throughout the system.Code Updates for New Metadata:
extract_wiresmethod inslac_db/generate.pyto include new mappings forMPSSPEED(asmps_speed) andMOTR_SWITCH_ON_CMD(astorque_enable), supporting the extended wire metadata.These changes standardize wire type information across the codebase and metadata files, enabling clearer differentiation between wire types for downstream processing and analysis.