Draft
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #908 +/- ##
==========================================
- Coverage 60.20% 59.75% -0.46%
==========================================
Files 102 103 +1
Lines 12802 12999 +197
==========================================
+ Hits 7707 7767 +60
- Misses 5095 5232 +137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A basic Z-plot widget.
The Z-plot widget is to plot data along a physical dimension of a facility (at SLAC the z-dimension of the accelerator) and provide a dynamic symbolic diagram of the facility corresponding to the given data points.
The idea here is that this basic Z-plot widget could serve as a base template z-plot widget. It provides a basic plotting widget, which could be used on it's own, but lacks more convenient methods for gathering data and corresponding symbols for the plot.
Question:
This is a draft PR because documentation is still being written at the moment. In the mean time I wanted to see if this would be something which would be a good fit for PyDM. If it is a good fit, are there any additional features or changes which could enhance this basic z-plot widget?
Motivation and Context
SLAC had a need for a z-plot to plot PVs along the accelerator. Offering up this stripped down version as a base z-plot widget in case other users of PyDM may have need for a similar widget.
How Has This Been Tested?
Tested on an example Gui.
Where Has This Been Documented?
documentation is still being worked on.
Screenshots: