Skip to content

ENH: basic Z-plot widget #908

Draft
YektaY wants to merge 4 commits intoslaclab:masterfrom
YektaY:zplot
Draft

ENH: basic Z-plot widget #908
YektaY wants to merge 4 commits intoslaclab:masterfrom
YektaY:zplot

Conversation

@YektaY
Copy link
Copy Markdown
Collaborator

@YektaY YektaY commented Aug 26, 2022

Description

A basic Z-plot widget.

The Z-plot widget is to plot data along a physical dimension of a facility (at SLAC the z-dimension of the accelerator) and provide a dynamic symbolic diagram of the facility corresponding to the given data points.

The idea here is that this basic Z-plot widget could serve as a base template z-plot widget. It provides a basic plotting widget, which could be used on it's own, but lacks more convenient methods for gathering data and corresponding symbols for the plot.

Question:

This is a draft PR because documentation is still being written at the moment. In the mean time I wanted to see if this would be something which would be a good fit for PyDM. If it is a good fit, are there any additional features or changes which could enhance this basic z-plot widget?

Motivation and Context

SLAC had a need for a z-plot to plot PVs along the accelerator. Offering up this stripped down version as a base z-plot widget in case other users of PyDM may have need for a similar widget.

How Has This Been Tested?

Tested on an example Gui.

Where Has This Been Documented?

documentation is still being worked on.

Screenshots:

Screen Shot 2022-08-26 at 9 26 44 AM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 26, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 25.23364% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.75%. Comparing base (275c26f) to head (cfd855c).
⚠️ Report is 1261 commits behind head on master.

Files with missing lines Patch % Lines
pydm/widgets/z_plot.py 23.80% 80 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   60.20%   59.75%   -0.46%     
==========================================
  Files         102      103       +1     
  Lines       12802    12999     +197     
==========================================
+ Hits         7707     7767      +60     
- Misses       5095     5232     +137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants