Skip to content

Conversation

@WilliamBergamin
Copy link
Contributor

Bump the release version and generate the docs

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (f1fb115) to head (ba358a5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1227   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's such a great day for a release too!! 🚀

No blocker for this PR, but I'm wondering if the changes to generated references are alright to keep with release PRs or if we'd eventually want this to exist adjacent to the release?

I have no suggestion or plan for that but am curious for your thoughts if that's interesting to you - FWIW the current process makes a lot of sense with showing the most recent reference!

@@ -1,3 +1,3 @@
"""Check the latest version at https://pypi.org/project/slack-bolt/"""

__version__ = "1.21.3"
__version__ = "1.22.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@WilliamBergamin
Copy link
Contributor Author

@zimeg in the past we've forgotten to generate the documentation this is why we release process 🤔 there might be a better way to do this

@WilliamBergamin WilliamBergamin merged commit 9390d0a into main Dec 18, 2024
14 checks passed
@WilliamBergamin WilliamBergamin deleted the v1.22.0 branch December 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants