Update uniswap v2 lockstake clipper callee

[SidestreamBurningBanana]

This PR adjusts the UniswapV2LockstakeCallee contract to support the updated LockstakeEngine. MKR support was removed from the callee in favour of supporting SKY only.

Notes:

• CI is expected to fail due to the tests for other callees being fragile / depending on the market

  • In order to test this specific callee, one can locally run:

    forge test --skip UniswapV3 Oasis PSM Curve UniswapV2Lp UniswapV2Callee OneInch Simulation --match-contract=UniswapV2LockstakeCallee

• Current version of the callee supports any UniV2 paths that start from SKY and end with DAI or USDS (in other words, SKY/USDS pool is supported, and potentially others).

[DaiFoundation-DevOps]

All committers have signed the CLA.

[SidestreamColdMelon]

TLDR: Good to deploy!

• ✅ lockstake submodule is updated to match the latest commit (5c065ee) in the relevant PR
• ✅ Constructor parameters are updated to no longer require MKR or the MkrSky converter (since it's now one-way)
• ✅ Input gem is expected to always be SKY
• ✅ Tests are updated to match original tests from the makerdao/lockstake PR
• ✅ All callee tests pass at the latest commit 28ebb22 (when executed using provided command)

$ forge test --skip UniswapV3 Oasis PSM Curve UniswapV2Lp UniswapV2Callee OneInch Simulation --match-contract=UniswapV2LockstakeCallee
[⠊] Compiling...
No files changed, compilation skipped

Ran 8 tests for src/test/UniswapV2LockstakeCallee.t.sol:UniswapV2LockstakeCalleeTest
[PASS] testCalleeTake_NoDelegate_NoStaking_SkyDai() (gas: 3447469)
[PASS] testCalleeTake_NoDelegate_NoStaking_SkyUsds() (gas: 3435353)
[PASS] testCalleeTake_NoDelegate_WithStaking_SkyDai() (gas: 3487142)
[PASS] testCalleeTake_NoDelegate_WithStaking_SkyUsds() (gas: 3475002)
[PASS] testCalleeTake_WithDelegate_NoStaking_SkyDai() (gas: 3483474)
[PASS] testCalleeTake_WithDelegate_NoStaking_SkyUsds() (gas: 3471379)
[PASS] testCalleeTake_WithDelegate_WithStaking_SkyDai() (gas: 3523062)
[PASS] testCalleeTake_WithDelegate_WithStaking_SkyUsds() (gas: 3510987)
Suite result: ok. 8 passed; 0 failed; 0 skipped; finished in 38.18s (22.44s CPU time)

Ran 1 test suite in 38.20s (38.18s CPU time): 8 tests passed, 0 failed, 0 skipped (8 total tests)

[SidestreamIcedMango]

Good to deploy!

Uniswap V2 Lockstake Clipper Callee Review

• Checked callee contract
  • Callee now expects SKY as a token to be exchanged, MKR token support is completely removed
  • No other changes were made
• Checked tests
  • Checked UniswapV2LockstakeCalleeTest tests
    • setUp
      • ✅ Matches with provided existing test function from Lockstake repo
    • _ink
      • ✅ Matches with provided existing test function from Lockstake repo
    • _art
      • ✅ Matches with provided existing test function from Lockstake repo
    • _urnSetUp
      • ✅ Matches with provided existing test function from Lockstake repo
    • _forceLiquidation
      • ✅ Matches with provided existing test function from Lockstake repo
    • _setMedianPrice
      • ✅ Matches with provided existing test function from Lockstake repo
    • setUpCallee
      • ✅ UniSwapV2LockstakeCallee call was correctly updated to only use sky token instead of mkrSky
    • _testCalleeTake
      • ✅ Test was updated to use sky instead of mkr
    • ✅ Checked that all testCalleeTake... tests were updated to remove mkrSky.rate() conversion for exchange rate
  • Checked all tests are passing locally using forge test
    • ℹ️ Used forge test command provided in PR comment

forge test --skip UniswapV3 Oasis PSM Curve UniswapV2Lp UniswapV2Callee OneInch Simulation --match-contract=UniswapV2LockstakeCallee
[⠊] Compiling...
No files changed, compilation skipped

Ran 8 tests for src/test/UniswapV2LockstakeCallee.t.sol:UniswapV2LockstakeCalleeTest
[PASS] testCalleeTake_NoDelegate_NoStaking_SkyDai() (gas: 3447469)
[PASS] testCalleeTake_NoDelegate_NoStaking_SkyUsds() (gas: 3435353)
[PASS] testCalleeTake_NoDelegate_WithStaking_SkyDai() (gas: 3487142)
[PASS] testCalleeTake_NoDelegate_WithStaking_SkyUsds() (gas: 3475002)
[PASS] testCalleeTake_WithDelegate_NoStaking_SkyDai() (gas: 3483474)
[PASS] testCalleeTake_WithDelegate_NoStaking_SkyUsds() (gas: 3471379)
[PASS] testCalleeTake_WithDelegate_WithStaking_SkyDai() (gas: 3523062)
[PASS] testCalleeTake_WithDelegate_WithStaking_SkyUsds() (gas: 3510987)
Suite result: ok. 8 passed; 0 failed; 0 skipped; finished in 11.01s (19.93s CPU time)

Ran 1 test suite in 11.01s (11.01s CPU time): 8 tests passed, 0 failed, 0 skipped (8 total tests)

[DaeunYoon]

Deployed contract lgtm

Verify callee deployment

• Address: 0x4dc81719909f72cadb3a5c63891fe2b5421cf36f
• PR: #45
• ✅ Source code is verified on etherscan
• ✅ Compilation optimizations, solidity version match deployment settings defined in the source code repo
• ✅ GNU AGPLv3 license
• ✅ All constructors are checked
  • uniRouter02_: 0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D matches uniswap official document
  • daiJoin_: 0x9759A6Ac90977b93B58547b4A71c78317f391A28 matches MCD_JOIN_DAI on chainlog
  • usdsJoin_: 0x3C0f895007CA717Aa01c8693e59DF1e8C3777FEB matches USDS_JOIN on chainlog
  • sky_: 0x56072C95FAA701256059aa122697B133aDEd9279 matches SKY on chainlog
• ✅ Contract doesn't have access control
• ✅ Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
• ✅ Contract was deployed by previously known address

[SidestreamColdMelon]

• ✅ Source code matches the code approved above
• ✅ Compilation optimizations match config
• ✅ Constructors match expected values
  • uniRouter02_ being 0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D (as in the uniswap v2 docs)
  • daiJoin_ being 0x9759A6Ac90977b93B58547b4A71c78317f391A28 (MCD_JOIN_DAI from chainlog)
  • usdsJoin_ being 0x3C0f895007CA717Aa01c8693e59DF1e8C3777FEB (USDS_JOIN from chainlog)
  • sky_ being 0x56072C95FAA701256059aa122697B133aDEd9279 (SKY from chainlog)
• ✅ Licence is correct
• ✅ addresses.json is updated