Conversation
Co-authored-by: Julien <80432849+julienmartinlevrai@users.noreply.github.com>
| } | ||
|
|
||
| function testTakeLpDaiEthNoProfit() public { | ||
| function testTakeLpDaiEthNoProfit() private { // most LP tokens are getting offboarded |
There was a problem hiding this comment.
Just a note that we have these tests replaced in a pending PR.
There was a problem hiding this comment.
You did a really great job of replacing these tests.
|
@talbaneth thank you for your review. I will be addressing it shortly. |
talbaneth
left a comment
talbaneth
left a comment
There was a problem hiding this comment.
Changes ok, tests pass.
LGTM for deploying.
Don't forget to add the address to addresses.json.
|
I see The test is trying to take 3K reth at price of 970 reth/dai with greater than zero profit. Was still failing for 2K but succeeded at 1.5K reth. |
|
@julienmartinlevrai @godsflaw please check and approve to merge |
julienmartinlevrai
left a comment
julienmartinlevrai
left a comment
There was a problem hiding this comment.
- contract deployed at mainnet address
0x7cdAb0fE16efb1EFE89e53B141347D7F299d6610 - contract code verified on Etherscan
- verified code matches the code of this PR
- addresses in constructor parameters correspond to the right contracts
- no libraries
- this contract does not use any type of auth
LGTM (I can’t approve my own PR though)
julienmartinlevrai
left a comment
julienmartinlevrai
left a comment
There was a problem hiding this comment.
Also, tests pass.
3 participants
Set to be merged after #30