[ENH] all regressors to use "dist" kwarg for distribution input#1008
Open
joshdunnlime wants to merge 1 commit intosktime:mainfrom
Open
[ENH] all regressors to use "dist" kwarg for distribution input#1008joshdunnlime wants to merge 1 commit intosktime:mainfrom
joshdunnlime wants to merge 1 commit intosktime:mainfrom
Conversation
this will override any of the following: distribution, dist_type, family, etc. There is a deprecation warning with minimum switchover period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will override any of the following:
distribution,dist_type,family, etc. There is a deprecation warning with minimum switch-over period.Reference Issues/PRs
#653
What does this implement/fix? Explain your changes.
Unifies the input kwarg name for distributions/distribution-like objects/str.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
Does the new name make this clearer? Are we happy with the deprecation warning?
Did you add any tests for the change?
No.
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.