[ENH] Add conditional test decorators to recently added tests #997#1001
Open
ANANYA542 wants to merge 2 commits intosktime:mainfrom
Open
[ENH] Add conditional test decorators to recently added tests #997#1001ANANYA542 wants to merge 2 commits intosktime:mainfrom
ANANYA542 wants to merge 2 commits intosktime:mainfrom
Conversation
Contributor
Author
|
@fkiraly please review the pr and let me know if some changes are required |
fkiraly
reviewed
Mar 28, 2026
| ) | ||
| from skpro.tests.test_switch import run_test_module_changed | ||
|
|
||
| pytestmark = pytest.mark.skipif( |
Collaborator
There was a problem hiding this comment.
I would make this more specific to the containing modules
fkiraly
requested changes
Mar 28, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Looks good! Just one change request above.
Contributor
Author
|
@fkiraly I have made the changes as requested if you could review once and let me know if this works? or need any further changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #997
What does this implement/fix? Explain your changes.
Adds @pytest.mark.skipif decorators using run_test_for_class and run_test_module_changed to recently added tests that were missing them. This ensures these tests only run on CI when the underlying class or module has changed, reducing unnecessary CI load.
Files changed (7):
Does your contribution introduce a new dependency? If yes, which one?
no
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
No new tests - this PR adds skip decorators to existing tests
Any other comments?
Tests that are already unconditionally skipped( test_proba_example, test_discreate_pmf_plotting - both marked with @pytest.mark.skip) were intentionally left without the conditional decorator as they are already skipped regardless.
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.