[ENH] isolate lookup tests to dedicated mock package by arnavk23 · Pull Request #476 · sktime/skbase

arnavk23 · 2025-11-22T08:05:34Z

Reference Issues/PRs

Fixes #114.

What does this implement/fix? Explain your changes.

This PR isolates lookup tests from the main package by introducing a dedicated test-only package, skbase.tests.mock_package.

The lookup tests scan this small controlled package instead of scanning skbase directly. This decouples lookup tests from unrelated production-package refactors and prevents brittle failures when internals outside lookup change.

Does your contribution introduce a new dependency? If yes, which one?

No.

What should a reviewer concentrate their feedback on?

Whether the new mock_package expectations accurately model intended lookup behavior.
Whether test coverage still protects public and non-public module/item filtering semantics.

Any other comments?

The intent is to make lookup tests deterministic and focused on lookup behavior, not on unrelated evolution of the production package structure.

PR checklist

For all contributions

I've reviewed the project documentation on contributing
I've added myself to the list of contributors.
The PR title starts with either [ENH], [CI/CD], [MNT], [DOC], or [BUG] indicating whether
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.

For code contributions

Unit tests have been added covering code functionality
Appropriate docstrings have been added (see documentation standards)
New public functionality has been added to the API Reference

)

…sktime#162)

…cope (fix issue sktime#114)

…isolate tests to skbase.tests.mock_package (fix sktime#114)

…e to improve mock coverage (edge cases)

for more information, see https://pre-commit.ci

…age __init__

for more information, see https://pre-commit.ci

+__author__: List[str] = ["fkiraly", "RNKuhns"]
+
+
+class Parent(BaseObject):


codecov · 2025-12-08T06:40:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.46%. Comparing base (306958d) to head (81bd3f9).
⚠️ Report is 198 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   85.07%   84.46%   -0.61%     
==========================================
  Files          45       52       +7     
  Lines        3015     3933     +918     
==========================================
+ Hits         2565     3322     +757     
- Misses        450      611     +161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…n mock_package modules Classes defined in test_fixtures.py should only appear in that module's metadata, not in __init__.py or test_mock_package.py where they're imported. Removed Parent, Child, ClassWithABTrue from __all__ lists to match the test's expectation that get_package_metadata only reports classes actually defined in each module (cls.__module__ == module.__name__).

…ckage Classes are imported for re-export to maintain the module's public API but are intentionally not listed in __all__ to ensure get_package_metadata only reports classes defined in each module.

for more information, see https://pre-commit.ci

fkiraly

Great!

There is though an entire config file which checks expectations against actuals after retrieval.

I would expect that still to happen for the mock package, but it does not - are you sure you have moved all tests over? I would at least expect the "full package expected lookup results" to be removed.

…strict the lookup tests to only those that are relevant to the issue at hand.

for more information, see https://pre-commit.ci

fkiraly

It feels like you are using AI to make changes.

You have made some changes related to my review request, but _conftest looks like a combination of changes that are sensible, some that are random and introduce issues.

Can you comment - after thinking about what you are doing? How did you address the changes and why?

fkiraly · 2026-04-19T19:38:42Z

Also, the mock package does not have private modules or functions - this reduces test coverage.

Coverage should not be reduced.

…them. Also added a test for the lookup function to check that it does not return private members.

for more information, see https://pre-commit.ci

…hub.com/arnavk23/skbase into fix/issue-114-restrict-lookup-tests

arnavk23 · 2026-04-19T20:22:09Z

@fkiraly Thank you for pointing that out. I have made some changes. Please review and do share if there is anything you need.

arnavk23 and others added 12 commits November 20, 2025 03:08

ENH: add regression test for HTML repr of meta-objects (fixes sktime#163

37150eb

)

ENH: add test for all_objects tag filtering (regression for sktime#161/…

b0ce58c

…sktime#162)

Delete skbase/base/_pretty_printing/tests/test_object_html_repr.py

b06f1fb

STYLE: wrap long docstring to satisfy flake8 E501

b5c9c06

tests(lookup): restrict package_name to skbase.tests to reduce scan s…

72a688c

…cope (fix issue sktime#114)

tests(lookup): use dedicated mock_package fixtures; add fixtures and …

ef2a3de

…isolate tests to skbase.tests.mock_package (fix sktime#114)

tests(mock_package): add public module, private module, and subpackag…

9dd4cd9

…e to improve mock coverage (edge cases)

[pre-commit.ci] auto fixes from pre-commit.com hooks

15b7935

for more information, see https://pre-commit.ci

style(tests): fix indentation (replace tabs with spaces) in mock_pack…

d670fa2

…age __init__

[pre-commit.ci] auto fixes from pre-commit.com hooks

95db0d0

for more information, see https://pre-commit.ci

tests(mock_package): remove old files renamed to test_* counterparts

08054cb

correcting test file names

cfc4d14

arnavk23 changed the title ~~tests(lookup): isolate lookup tests to dedicated mock package~~ [ENH] tests(lookup): isolate lookup tests to dedicated mock package Nov 22, 2025

github-advanced-security AI found potential problems Nov 28, 2025

View reviewed changes

fixing tags

6e00981

github-advanced-security AI found potential problems Dec 15, 2025

View reviewed changes

Comment thread skbase/utils/tests/test_deep_equals_jax.py Fixed

arnavk23 force-pushed the fix/issue-114-restrict-lookup-tests branch 2 times, most recently from 0c30a63 to 6e00981 Compare December 15, 2025 15:45

arnavk23 and others added 11 commits December 15, 2025 21:19

Fix flake8 B043 error: use variable for delattr attribute name

0174af9

Add arnavk23 (Arnav Kapoor) to contributors list

cea639d

actual representation against the expected representation

d36b14a

Fix flake8 F401: add noqa comments for re-exported classes in mock_pa…

5467010

…ckage Classes are imported for re-export to maintain the module's public API but are intentionally not listed in __all__ to ensure get_package_metadata only reports classes defined in each module.

[pre-commit.ci] auto fixes from pre-commit.com hooks

3a45ea6

for more information, see https://pre-commit.ci

Merge branch 'main' into fix/issue-114-restrict-lookup-tests

0d901dc

Merge branch 'main' into pr/476

31fcf6d

Update test_base.py

fac3d04

Merge branch 'main' into fix/issue-114-restrict-lookup-tests

20a572b

Merge branch 'main' into fix/issue-114-restrict-lookup-tests

a8946f8

arnavk23 and others added 3 commits January 24, 2026 01:40

Merge branch 'main' into fix/issue-114-restrict-lookup-tests

a1a97cb

[pre-commit.ci] auto fixes from pre-commit.com hooks

36e61c3

for more information, see https://pre-commit.ci

Merge branch 'main' into fix/issue-114-restrict-lookup-tests

b088695

fkiraly requested changes Feb 13, 2026

View reviewed changes

arnavk23 and others added 3 commits February 14, 2026 12:56

removal of tests that are not relevant to the lookup tests, and to re…

c86f4e4

…strict the lookup tests to only those that are relevant to the issue at hand.

[pre-commit.ci] auto fixes from pre-commit.com hooks

3b74e86

for more information, see https://pre-commit.ci

flake8

46e0a8b

fkiraly reviewed Mar 5, 2026

View reviewed changes

Comment thread skbase/tests/test_lookup.py Outdated

fkiraly mentioned this pull request Mar 5, 2026

[ENH] Add regression test ensuring filter_tags in all_objects does not return empty results #512

Open

arnavk23 added 4 commits March 6, 2026 02:05

Merge branch 'main' into fix/issue-114-restrict-lookup-tests

dc489fd

Update test_lookup.py

e3e889e

Update .all-contributorsrc

acc90cd

adding changes

188b76a

arnavk23 requested a review from fkiraly March 6, 2026 05:32

Merge branch 'main' into pr/476

e0cab6c

fkiraly requested changes Apr 19, 2026

View reviewed changes

fkiraly added enhancement Adding new functionality AI overuse suspected labels Apr 19, 2026

fkiraly changed the title ~~[ENH] tests(lookup): isolate lookup tests to dedicated mock package~~ [ENH] isolate lookup tests to dedicated mock package Apr 19, 2026

arnavk23 and others added 5 commits April 20, 2026 01:13

added private class and function to mock package and added tests for …

bd77634

…them. Also added a test for the lookup function to check that it does not return private members.

[pre-commit.ci] auto fixes from pre-commit.com hooks

b675afa

for more information, see https://pre-commit.ci

pre-commit

69d395a

Merge branch 'fix/issue-114-restrict-lookup-tests' of https://www.git…

7761319

…hub.com/arnavk23/skbase into fix/issue-114-restrict-lookup-tests

Merge branch 'main' into fix/issue-114-restrict-lookup-tests

81bd3f9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENH] isolate lookup tests to dedicated mock package#476

[ENH] isolate lookup tests to dedicated mock package#476
arnavk23 wants to merge 40 commits intosktime:mainfrom
arnavk23:fix/issue-114-restrict-lookup-tests

arnavk23 commented Nov 22, 2025 •

edited

Loading

Uh oh!

Check warning

codecov bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

fkiraly left a comment

Uh oh!

Uh oh!

fkiraly left a comment

Uh oh!

fkiraly commented Apr 19, 2026

Uh oh!

arnavk23 commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		__author__: List[str] = ["fkiraly", "RNKuhns"]


		class Parent(BaseObject):

Conversation

arnavk23 commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

For code contributions

Uh oh!

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

fkiraly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fkiraly left a comment

Choose a reason for hiding this comment

Uh oh!

fkiraly commented Apr 19, 2026

Uh oh!

arnavk23 commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arnavk23 commented Nov 22, 2025 •

edited

Loading

codecov bot commented Dec 8, 2025 •

edited

Loading