Skip to content

[ENH] deduplicate dependency checkers and isolate soft dependency imports by using skbase#13

Open
fkiraly wants to merge 10 commits intomasterfrom
checks-refactor
Open

[ENH] deduplicate dependency checkers and isolate soft dependency imports by using skbase#13
fkiraly wants to merge 10 commits intomasterfrom
checks-refactor

Conversation

@fkiraly
Copy link
Copy Markdown

@fkiraly fkiraly commented Feb 15, 2025

This PR deduplicates dependency checkers by using skbase, which is currently an implied dependency, and which contains equivalent functionality.

This improves maintainability of the dependencies module through deduplication.

Importantly, it also helps with soft dependency isolation because the skbase dependency checker does not actually import all modules while checking - making future work on reducing impact of soft dependencies easier.

In line with best practice, packaging and scikit-base are added as dependencies to pyproject.toml, since there are now direct imports.

No deprecation or change period is necessary, since both packages were already implied by core dependencies.

Requires pycaret#4124 because we are using pyproject.toml.

@fkiraly fkiraly added the ci / build Continuous integration, unit testing & package distribution label Feb 15, 2025
@amotl
Copy link
Copy Markdown
Collaborator

amotl commented Feb 19, 2025

The patch has been submitted to upstream. Thanks a stack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci / build Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants