Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| { | ||
| "asset_type": "erc20", | ||
| "erc20_contract_address": "0xbC396689893D065F41bc2C6EcbeE5e0085233447", | ||
| "erc20_contract_address": "0xbc396689893D065F41bc2C6EcbeE5e0085233447", |
There was a problem hiding this comment.
Undocumented PERP address change breaks EIP-55 checksum
Low Severity
The PERP token erc20_contract_address was changed from 0xbC396689893D065F41bc2C6EcbeE5e0085233447 to 0xbc396689893D065F41bc2C6EcbeE5e0085233447 (capital C to lowercase c). This modification is undocumented in the PR description and changes the address from a valid EIP-55 checksum format to an invalid one. Systems that validate EIP-55 checksums may reject this address. The change appears unrelated to the PR's stated purpose of adding EURC, stETH, and wstETH tokens.
|
You need to run validation on this and change the PERP denom, then I can approve |
2 participants
Add on Ethereum (chainid:1)
Note
Adds three ERC-20 assets to Ethereum
assetlist.jsonand normalizes one address.stETH(Lido Staked Ether),wstETH(Wrapped stETH),EURC(Euro Coin) with symbols, decimals, logos, and CoinGecko IDsperpetual-protocolcontract address casing (0xbc3966...3447)Written by Cursor Bugbot for commit f7cb188. This will update automatically on new commits. Configure here.