replace qprompt with click for new-config#592
Merged
Conversation
liquidpele
reviewed
Apr 2, 2026
| import os.path | ||
|
|
||
| import qprompt | ||
| import click |
There was a problem hiding this comment.
recommend moving the click import into the function that uses it, unless you want it as a hard requirement, if you do then don't forget to add it to the toml where you removed qprompt.
Contributor
Author
There was a problem hiding this comment.
click has been a hard requirement of cosmic ray for years, so it's already in the pyproject.toml dependencies. Honestly, I've never been a big fan of this feature of new_config(), so this is making me rethinking if the prompting should a) exist and b) be put in the CLI more directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.