ci: make container-image publishing non-blocking#8
Open
sirredbeard wants to merge 1 commit into
Open
Conversation
The publish-image job builds Windows container images after the binary release. arm64 Windows container images cannot be built on GitHub-hosted windows-11-arm runners (no Docker engine / Windows Containers feature), so that matrix leg always fails and, via matrix fail-fast, was canceling the amd64 image job too. Make image publishing best-effort so it never blocks the win-x64 / win-arm64 binary build and GitHub release: - continue-on-error: true on the publish-image job - fail-fast: false so amd64 completes independently of arm64 The arm64 image leg can light up later once a self-hosted arm64 Windows runner with Docker is available.
There was a problem hiding this comment.
Pull request overview
Makes the publish-image job best-effort so failures in Windows container image builds (particularly the arm64 leg, which cannot run on GitHub-hosted windows-11-arm runners without Docker) do not block the primary binary release artifacts.
Changes:
- Adds
continue-on-error: trueto thepublish-imagejob with an explanatory comment. - Adds
fail-fast: falseto the matrix so the amd64 leg is not canceled when arm64 fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the
publish-imagejob inrelease.ymlbest-effort so it can never block the binary build + GitHub release.continue-on-error: trueon thepublish-imagejobfail-fast: falseon its matrixWhy
The
win-x64/win-arm64runner binaries (built by thebuildandreleasejobs) are the primary release artifacts. Thepublish-imagejob builds Windows container images afterward.arm64 Windows container images cannot be built on GitHub-hosted
windows-11-armrunners — those images ship no Docker engine and no Windows Containers feature. So the arm64 leg always fails, and with the default matrixfail-fastit was also canceling the amd64 image job mid-build.With this change, the arm64 image leg can fail without failing the workflow, and the amd64 image builds independently. The arm64 container image can light up later once a self-hosted arm64 Windows runner with Docker is available.
Notes
Add Windows Containers Supportcommit convention; squash on merge to keep one commit above upstream.