Quality: Global mutable call id can grow unbounded across long-lived processes#2691
Open
tuanaiseo wants to merge 1 commit intosinonjs:mainfrom
Conversation
`callId` is module-scoped and incremented on every invocation. In long-running test runners or embedded usage, this can grow indefinitely and eventually lose integer precision semantics for strict ordering comparisons. Affected files: proxy-invoke.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
fatso83
requested changes
Apr 9, 2026
Contributor
fatso83
left a comment
fatso83
left a comment
There was a problem hiding this comment.
Thanks for noticing! Just a minor note.
| const matchings = this.matchingFakes(args); | ||
| const currentCallId = callId++; | ||
| const currentCallId = callId; | ||
| callId = callId === maxSafeInteger ? 0 : callId + 1; |
Contributor
There was a problem hiding this comment.
Maybe replace that
Suggested change
| callId = callId === maxSafeInteger ? 0 : callId + 1; | |
| callId = callId >= maxSafeInteger ? 0 : callId + 1; |
And we require a test 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
callIdis module-scoped and incremented on every invocation. In long-running test runners or embedded usage, this can grow indefinitely and eventually lose integer precision semantics for strict ordering comparisons.Severity:
lowFile:
lib/sinon/proxy-invoke.jsSolution
Reset or wrap
callIdsafely (e.g., moduloNumber.MAX_SAFE_INTEGER) and document ordering guarantees when rollover occurs.Changes
lib/sinon/proxy-invoke.js(modified)Testing