Skip to content

improve workflows #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
till wants to merge 2 commits into
base: main
Choose a base branch
from
+42 −11
Open

improve workflows #2686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63d63e7
fix(workflows): fetch-depth is for actions/checkout
till Apr 5, 2026
80bb9d0
chore(workflows): update
till Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,9 @@ updates:
directory: "/"
schedule:
interval: "weekly"
cooldown:
default-days: 7
groups:
action-deps:
patterns:
- "*"
44 changes: 33 additions & 11 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@ jobs:
prettier:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
fetch-depth: 2
persist-credentials: false
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
Comment on lines +18 to +23
Copy link
Copy Markdown
Contributor

@fatso83 fatso83 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems dodgy as fsck. Tagged releases only.

Copy link
Copy Markdown
Contributor Author

@till till Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags are still as comments and Dependabot supports this too.

The hash is updated using zismor. It's generally considered to be best practice as all other "references" may not be immutable.

Copy link
Copy Markdown
Contributor

@fatso83 fatso83 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha, ok. well maybe that's OK. does not this entail that we need to check every update manually?

Copy link
Copy Markdown
Contributor Author

@till till Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you mean?

Copy link
Copy Markdown
Contributor

@fatso83 fatso83 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, to know that a commit is not dodgy, we would need to manually check it out in the repository, see that it corresponds to a known (good) release, before accepting a change.

Copy link
Copy Markdown
Contributor Author

@till till Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rely on automation. E.g. zimor can run and audit.

In addition, the cooldown period quiets it down a bit. So a new release is not offered up by dependabot immediately.

Copy link
Copy Markdown
Contributor Author

@till till Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example:

Warning: pr.yml:75: detects commit SHAs that don't match their version comment tags: points to commit 65f9e5c9a1f2
Error: Process completed with exit code 13.

node-version: "lts/*"
cache: "npm"
- name: Install dependencies
Expand All @@ -34,10 +36,12 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
fetch-depth: 2
persist-credentials: false
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "lts/*"
cache: "npm"
- name: Install dependencies
Expand All @@ -52,10 +56,12 @@ jobs:
browser-test:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
fetch-depth: 2
persist-credentials: false
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "lts/*"
cache: "npm"
- name: Install dependencies
Expand All @@ -82,10 +88,12 @@ jobs:
if: ${{ github.ref == 'refs/heads/main' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
fetch-depth: 2
persist-credentials: false
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: "lts/*"
cache: "npm"
- name: Install dependencies
Expand All @@ -108,11 +116,13 @@ jobs:
node-version: [20, 22, 24]

steps:
- uses: actions/checkout@v6
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
fetch-depth: 2
persist-credentials: false
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: ${{ matrix.node-version }}
cache: "npm"
- name: Install dependencies
Expand All @@ -122,3 +132,15 @@ jobs:
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: 1
- name: npm test
run: npm run test-node

validate-workflows:
permissions:
security-events: write
contents: read
actions: read
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- uses: zizmorcore/zizmor-action@71321a20a9ded102f6e9ce5718a2fcec2c4f70d8 # v0.5.2
3 changes: 3 additions & 0 deletions .github/zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
rules:
secrets-outside-env:
disable: true
Loading