Fix issue 2668 - Perform additional cleanup on callThrough() to discard any previously defined behavior#2670
Open
Sigill wants to merge 4 commits intosinonjs:mainfrom
Open
Fix issue 2668 - Perform additional cleanup on callThrough() to discard any previously defined behavior#2670Sigill wants to merge 4 commits intosinonjs:mainfrom
Sigill wants to merge 4 commits intosinonjs:mainfrom
Conversation
Sigill
force-pushed
the
fix-issue-2668
branch
2 times, most recently
from
6cd60f4 to
5c7a7eb
Compare
Sigill
force-pushed
the
fix-issue-2668
branch
2 times, most recently
from
e96a8aa to
641a5cd
Compare
Contributor
|
This seems fine to me! Could you rebase on the latest |
The cleanup for callThroughWithNew() could be the same as for callThrough(). But in the callThroughWithNew() context, we are dealing with constructors, which means the returnThis, resolves, resolvesArg, resolvesthis, rejects, returnsArg and callsFake don't apply. The callsArg/yield stuff still applies and needs to be cleaned-up.
Author
|
@fatso83 Sure, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #2668 by cleanup all other behaviors when calling callThrough()
How to verify - mandatory
npm installnpm run testChecklist for author
npm run lintpasses