fix: remove Partial from Dependency type - #1493
Open
dword-design wants to merge 1 commit into
Open
Conversation
som-sm
requested changes
Aug 1, 2026
som-sm
left a comment
Collaborator
There was a problem hiding this comment.
This PR makes sense because undefined should not be allowed as a valid value. undefined should only come up while accessing an unknown property from an index signature, which can be enforced using noUncheckedIndexedAccess compiler option.
// @noUncheckedIndexedAccess: true
declare const x: {[x: string]: number};
const y = x.foo;
//=> number | undefined
// @ts-expect-error
x.bar = undefined; // Not allowedBut all instances of Partial<Record<... need fixing, not just Dependency.
Also, the failing tests are related to this change, so tests need to be updated as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Dependency type is a partial of
Record<string, string>, which allows{ 'type-fest': undefined }.Tests are failing but I think they are not related.