Derive the standard Error trait using the thiserror crate#13
Open
therustmonk wants to merge 1 commit intosigp:mainfrom
Open
Derive the standard Error trait using the thiserror crate#13therustmonk wants to merge 1 commit intosigp:mainfrom
therustmonk wants to merge 1 commit intosigp:mainfrom
Conversation
macladson
requested changes
Oct 7, 2025
Member
macladson
left a comment
There was a problem hiding this comment.
Hi, thanks for the PR! I agree we should implement std::error::Error however personally I think using thiserror is overkill in this situation since the error type is small and we don't have any nested errors where we need to track error sources.
We should just implement Display manually and then implement the default implementation of std::error::Error, like this:
impl std::error::Error for Error {}It's slightly more boilerplate but it saves us a dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the
Errortype by implementing thestd::error::Errortrait with the aid of thethiserrorcrate.This enhancement will streamline the process of integrating this error type with various other error management strategies.