DEMRUM-3301: Include Gradle plugins - #1325
Conversation
Signed-off-by: Tomas Chladek <tchladek@splunk.com>
|
@TomasChladekSL Please fix build and ktlint. Thanks. |
SenNeonoveNoci
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| gradlePlugin { | ||
| plugins { | ||
| create("androidInstrumentationPlugin") { | ||
| id = "$defaultGroupId.${artifactPrefix}httpurlconnection-auto-plugin" | ||
| implementationClass = "com.splunk.rum.httpurlconnection.auto.plugin.HttpURLInstrumentationPlugin" | ||
| displayName = "Splunk Android HttpURLConnection Auto-Instrumentation Plugin" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { |
There was a problem hiding this comment.
The httpurlconnection-auto module still applies java-gradle-plugin but no longer declares a gradlePlugin { plugins { … } } entry (it used to sit between tasks.jar and dependencies). The published artifact added under instrumentation/buildtime/httpurlconnection-auto/plugin/repo now contains no META-INF/gradle-plugins/* marker (checked with jar tf … | grep gradle-plugins), so plugins { id("com.splunk.android.rum-httpurlconnection-auto-plugin") } or apply(plugin = …) will fail with “plugin not found” even though the repository and classpath dependencies were added. Restore the plugin definition so the plugin id resolves.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| gradlePlugin { | ||
| plugins { | ||
| create("androidInstrumentationPlugin") { | ||
| id = "$defaultGroupId.${artifactPrefix}okhttp3-auto-plugin" | ||
| implementationClass = "com.splunk.rum.okhttp3.auto.plugin.OkHttp3InstrumentationPlugin" | ||
| displayName = "Splunk Android OkHttp3 Auto-Instrumentation Plugin" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { |
There was a problem hiding this comment.
Similarly, the OkHttp3 auto-instrumentation module keeps java-gradle-plugin applied but has dropped the gradlePlugin block that registers the plugin id; the area between tasks.jar and dependencies is now empty. The bundled artifact in instrumentation/buildtime/okhttp3-auto/plugin/repo has no META-INF/gradle-plugins/* entries, so attempting to apply com.splunk.android.rum-okhttp3-auto-plugin from the newly added repository will fail because Gradle cannot map the id to an implementation class. Reintroduce the plugin definition so consumers can apply the plugin by id.
Useful? React with 👍 / 👎.
2 participants
No description provided.