hid_close close handle immediately at win32#416
Open
LianYangCn wants to merge 2 commits intosignal11:masterfrom
Open
hid_close close handle immediately at win32#416LianYangCn wants to merge 2 commits intosignal11:masterfrom
LianYangCn wants to merge 2 commits intosignal11:masterfrom
Conversation
…ely-on-win32 Update hid.c, fix hid_close block by the hid_read
|
Please consider making this PR at https://github.com/libusb/hidapi |
Author
Ok, see libusb/hidapi#41 |
|
Thank you for trying anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-thread environment, if the hid_read thread is different from the hid_close thread, the hid_read function will block the thread exiting, at the wait object operation.
This fix just set the event, after cancel io, so that, hid_read not wait anymore and exiting read