Skip to content

feat(icon): enable svg icons by default#1508

Merged
spike-rabbit merged 1 commit intomainfrom
feat/enable/svg
Feb 17, 2026
Merged

feat(icon): enable svg icons by default#1508
spike-rabbit merged 1 commit intomainfrom
feat/enable/svg

Conversation

@chintankavathia
Copy link
Member

BREAKING CHANGE: icons are now rendered as SVG by default instead of icon fonts.

Applications that rely on icon fonts must explicitly opt out by using:

provideIconConfig({ disableSvgIcons: true })

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default icon rendering to use SVGs and cleans up demo app configuration. While a functional improvement, enabling SVG icons by default introduces a critical Cross-Site Scripting (XSS) vulnerability due to unsanitized SVG content. Furthermore, a critical issue with unit tests needs to be resolved.

@chintankavathia chintankavathia force-pushed the feat/enable/svg branch 2 times, most recently from ab857f0 to 0d4293c Compare February 12, 2026 10:29
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

@chintankavathia chintankavathia force-pushed the feat/enable/svg branch 4 times, most recently from 8ad19e0 to 88fb396 Compare February 12, 2026 15:24
@chintankavathia chintankavathia marked this pull request as ready for review February 12, 2026 15:54
@chintankavathia chintankavathia requested review from a team as code owners February 12, 2026 15:54
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait if we can have the icons as CSS masks.

@spike-rabbit spike-rabbit added this to the 49.0.0 milestone Feb 16, 2026
@chintankavathia chintankavathia force-pushed the feat/enable/svg branch 2 times, most recently from bc9079c to dbe5e99 Compare February 17, 2026 07:06
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise everything is good. I just think we should chnange the breaking change note. Otherwise I am afraid we spook people out.
I guess something like this might be better:


BREAKING CHANGE: <si-icon> now renders icons by default as SVG instead of using the icon-font. element-* icon classes are not affected by this change.

SVG icons render slightly differently so VRT snapshots may need to be updated.

To restore the previous behavior, opt-out SVG icons.

  provideIconConfig({ disableSvgIcons: true })

@chintankavathia chintankavathia force-pushed the feat/enable/svg branch 3 times, most recently from e442c1a to a57a9e8 Compare February 17, 2026 12:59
BREAKING CHANGE: `<si-icon>` now renders icons by default as SVG instead of using the icon-font.
`element-*` icon classes are not affected by this change.

SVG icons render slightly differently so VRT snapshots may need to be updated.

To restore the previous behavior, opt-out SVG icons.
```ts
provideIconConfig({ disableSvgIcons: true })
```
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

Code Coverage

@spike-rabbit spike-rabbit merged commit 9093f59 into main Feb 17, 2026
19 of 27 checks passed
@spike-rabbit spike-rabbit deleted the feat/enable/svg branch February 17, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants