feat(icon): enable svg icons by default#1508
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the default icon rendering to use SVGs and cleans up demo app configuration. While a functional improvement, enabling SVG icons by default introduces a critical Cross-Site Scripting (XSS) vulnerability due to unsanitized SVG content. Furthermore, a critical issue with unit tests needs to be resolved.
ab857f0 to
0d4293c
Compare
|
Documentation. Coverage Reports: |
8ad19e0 to
88fb396
Compare
88fb396 to
4ee6527
Compare
spike-rabbit
left a comment
There was a problem hiding this comment.
Lets wait if we can have the icons as CSS masks.
projects/element-ng/chat-messages/si-chat-input.component.spec.ts
Outdated
Show resolved
Hide resolved
4ee6527 to
f311a2b
Compare
bc9079c to
dbe5e99
Compare
spike-rabbit
left a comment
There was a problem hiding this comment.
Code-wise everything is good. I just think we should chnange the breaking change note. Otherwise I am afraid we spook people out.
I guess something like this might be better:
BREAKING CHANGE: <si-icon> now renders icons by default as SVG instead of using the icon-font. element-* icon classes are not affected by this change.
SVG icons render slightly differently so VRT snapshots may need to be updated.
To restore the previous behavior, opt-out SVG icons.
provideIconConfig({ disableSvgIcons: true })e442c1a to
a57a9e8
Compare
BREAKING CHANGE: `<si-icon>` now renders icons by default as SVG instead of using the icon-font.
`element-*` icon classes are not affected by this change.
SVG icons render slightly differently so VRT snapshots may need to be updated.
To restore the previous behavior, opt-out SVG icons.
```ts
provideIconConfig({ disableSvgIcons: true })
```
a57a9e8 to
e7fa099
Compare
BREAKING CHANGE: icons are now rendered as SVG by default instead of icon fonts.
Applications that rely on icon fonts must explicitly opt out by using: