fix(browser-tests): V2 landing assertions, real auth selectors, demo specs split out - #92
Merged
Merged
Conversation
The landing specs asserted the V1 page (approval/accountability hero,
pricing '5 agents', NeuralTrust stat) — the live page is V2 ('the
missing control plane for agentic AI', no pricing section, compliance
trust bar). Assertions now match what the page actually renders.
Auth specs and helpers used input[name=...] selectors; the login and
signup inputs have ids only. All converted to #id.
Local CI-mode run of 01/02/03: 18 passed, 0 failed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
demo-healthcare specs target :3005, which the managed webServer set has never included — they surfaced as 'did not run' locally and as failures once CI infrastructure worked. Default e2e project now ignores specs/demo/**; a 'demos' project keeps them runnable on demand with the demo apps up. Core suite local CI-mode result: 59 passed / 0 failed / 1 known-flaky. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29089030 | Triggered | Generic Password | 8ebbcf7 | tests/browser/global-setup.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root causes 8–10, all spec-drift now that the CI infrastructure works:
input[name=…]— the login/signup inputs have ids only. Converted to#idacross specs, helpers, and global-setup.demosproject (--project=demoswith the demo apps up); the default run ignores them.Full local CI-mode suite: 59 passed / 0 failed / 1 known-flaky (passes on retry) / 5 skipped. Will chain validation #8 after merge — expected green.
🤖 Generated with Claude Code