fix(browser-tests): scope NODE_ENV per server in CI - #91
Merged
Conversation
…uilds The CI job exports NODE_ENV=development for the API's dev auth bypass (#87), which poisons 'next build': prerender runs with the dev React runtime and fails on /404 with the misleading '<Html> imported outside _document' error. The two Next apps now build and serve with an explicit NODE_ENV=production; the API inherits development as intended. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause #7, a collision between two earlier fixes: the job-wide
NODE_ENV=development(#87, needed for the API's dev auth bypass) poisonsnext build(#90's production servers) — prerender runs with the dev React runtime and fails on/404with the misleading<Html> should not be imported outside pages/_documenterror (run 30464116024).Fix: the two Next apps build and serve under an explicit
NODE_ENV=productioninside their webServer commands; the API keeps inheritingdevelopment. Will chain validation #7 after merge.🤖 Generated with Claude Code