Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions CI workflow for this Python package to automatically run quality gates and tests on pushes to main and on pull requests.
Changes:
- Added a CI workflow that sets up Python and installs dependencies/tools.
- Enforced linting + formatting checks via
ruff. - Added type checking via
basedpyrightand test execution viaunittest.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/shyndman/ptouch-bt/sessions/691de6e5-6fbb-49d7-9880-a42587ceed61 Co-authored-by: shyndman <42326+shyndman@users.noreply.github.com>
fa7667f to
9a98c15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions workflow to automate continuous integration (CI) for the repository. The workflow sets up Python, installs dependencies, enforces code quality with linting and formatting checks, performs type checking, and runs unit tests on every pull request and push to the
mainbranch.New CI workflow automation:
Added
.github/workflows/ci.ymlto define a CI pipeline that triggers on pull requests and pushes tomain.ruff(for linting/formatting) andbasedpyright(for type checking).rufffor linting and formatting checks to enforce code quality.basedpyrightfor type checking, outputs diagnostics, and fails the workflow on type errors.unittestframework.This addition ensures that code quality and correctness are automatically validated on each change, helping to prevent regressions and maintain standards.
Agent-Logs-Url: https://github.com/shyndman/ptouch-bt/sessions/691de6e5-6fbb-49d7-9880-a42587ceed61