Skip to content

Add menu_name setting to be able to make multiple instances of this app possible.#23

Open
RicardoMusch wants to merge 3 commits intoshotgunsoftware:masterfrom
NodesLayers:master
Open

Add menu_name setting to be able to make multiple instances of this app possible.#23
RicardoMusch wants to merge 3 commits intoshotgunsoftware:masterfrom
NodesLayers:master

Conversation

@RicardoMusch
Copy link
Copy Markdown

Add menu_name setting to be able to make multiple instances of this app possible.

@julien-lang julien-lang requested a review from Copilot June 23, 2025 15:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a configurable menu_name setting so multiple instances of the app can use different menu labels.

  • Adds a new menu_name configuration entry with a default value matching the previous hardcoded title.
  • Updates app.py to use the menu_name setting instead of a fixed string.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
info.yml Added menu_name setting under configuration with default and description.
app.py Replaced hardcoded "Open in Associated Application" title with self.get_setting("menu_name").
Comments suppressed due to low confidence (2)

info.yml:17

  • Consider updating the project README or user guide to document the new menu_name setting, including its default behavior and instructions for customization.
    menu_name:

app.py:42

  • Add or update unit tests to cover the new menu_name setting, ensuring the menu title reflects the configured value at runtime.
            "title": self.get_setting("menu_name"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants