Add menu_name setting to be able to make multiple instances of this app possible.#23
Open
RicardoMusch wants to merge 3 commits intoshotgunsoftware:masterfrom
Open
Add menu_name setting to be able to make multiple instances of this app possible.#23RicardoMusch wants to merge 3 commits intoshotgunsoftware:masterfrom
RicardoMusch wants to merge 3 commits intoshotgunsoftware:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable menu_name setting so multiple instances of the app can use different menu labels.
- Adds a new
menu_nameconfiguration entry with a default value matching the previous hardcoded title. - Updates
app.pyto use themenu_namesetting instead of a fixed string.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| info.yml | Added menu_name setting under configuration with default and description. |
| app.py | Replaced hardcoded "Open in Associated Application" title with self.get_setting("menu_name"). |
Comments suppressed due to low confidence (2)
info.yml:17
- Consider updating the project README or user guide to document the new
menu_namesetting, including its default behavior and instructions for customization.
menu_name:
app.py:42
- Add or update unit tests to cover the new
menu_namesetting, ensuring the menu title reflects the configured value at runtime.
"title": self.get_setting("menu_name"),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
menu_namesetting to be able to make multiple instances of this app possible.