Skip to content

[18.0] [ADD] shopinvader_router_helper#1616

Open
paradoxxxzero wants to merge 3 commits intoshopinvader:18.0from
akretion:18.0-add-shopinvader_router_helper
Open

[18.0] [ADD] shopinvader_router_helper#1616
paradoxxxzero wants to merge 3 commits intoshopinvader:18.0from
akretion:18.0-add-shopinvader_router_helper

Conversation

@paradoxxxzero
Copy link
Contributor

@paradoxxxzero paradoxxxzero commented Jan 20, 2026

This first 18.0 PR introduce a new way to handle router odoo-inheritable code.

It fixes several problems that arises when using directly AbstractModel.new in 18.0 by introducing a new VirtualModel.

It also provides an helper with common CRUD methods with a new security approach and includes and replaces shopinvader_filtered_model.

This helper is aimed to be used in all shopinvader modules that does CRUD on odoo models.

Depends on OCA/rest-framework#587

@paradoxxxzero paradoxxxzero marked this pull request as ready for review January 20, 2026 17:57
@paradoxxxzero paradoxxxzero force-pushed the 18.0-add-shopinvader_router_helper branch from 76ef644 to 285499c Compare January 21, 2026 08:56
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 95.05814% with 17 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (18.0@34d1480). Learn more about missing BASE report.

Files with missing lines Patch % Lines
shopinvader_router_helper/helper.py 82.75% 15 Missing ⚠️
shopinvader_router_helper/tests/common.py 90.90% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             18.0    #1616   +/-   ##
=======================================
  Coverage        ?   95.05%           
=======================================
  Files           ?        7           
  Lines           ?      344           
  Branches        ?       11           
=======================================
  Hits            ?      327           
  Misses          ?       15           
  Partials        ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paradoxxxzero paradoxxxzero force-pushed the 18.0-add-shopinvader_router_helper branch from 67660a6 to ef11d45 Compare January 21, 2026 09:08
@paradoxxxzero paradoxxxzero force-pushed the 18.0-add-shopinvader_router_helper branch 3 times, most recently from 127e203 to c7c4114 Compare January 21, 2026 12:38
@paradoxxxzero paradoxxxzero force-pushed the 18.0-add-shopinvader_router_helper branch from 491bf83 to fd8757b Compare February 4, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants