Skip to content

Add maria-back-me-up#132

Open
federico-razzoli wants to merge 1 commit intoshlomi-noach:masterfrom
Vettabase:add-maria-back-me-up
Open

Add maria-back-me-up#132
federico-razzoli wants to merge 1 commit intoshlomi-noach:masterfrom
Vettabase:add-maria-back-me-up

Conversation

@federico-razzoli
Copy link
Contributor

The license is Apache 2.

@dveeden
Copy link
Collaborator

dveeden commented Jul 2, 2024

Looks ok to me except for a small issue:

https://github.com/sapcc/maria-back-me-up/blob/master/mysql-utilities-1.6.5.tar.gz seems to be a tarball of https://github.com/mysql/mysql-utilities and probably under the GPLv2 license instead of Apache 2...

Looks like this is used in the Dockerfile. I don't think the MySQL Utilities are really maintained and neither is python2 isn't it?

@dveeden dveeden requested a review from shlomi-noach July 2, 2024 15:03
@dveeden
Copy link
Collaborator

dveeden commented Jul 2, 2024

Looks like the last commit is more than a year ago. Not really a problem, but not great either.

The pull requests have many dependabot ones for dependencies that are in need of an update, including security updates.

@shlomi-noach
Copy link
Owner

https://github.com/sapcc/maria-back-me-up/blob/master/mysql-utilities-1.6.5.tar.gz seems to be a tarball of https://github.com/mysql/mysql-utilities and probably under the GPLv2 license instead of Apache 2

Had to look it up. Apache2 is compliant with GPLv3 but not with GPLv2. I'm still not sure if that matters because the GPL code is tarballed as a distinct artifact rather than used as a library, but I'm not a lawyer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants