ForbidCheckedExceptionInYieldingMethod: skip closures handled by callable rule#356
Draft
ForbidCheckedExceptionInYieldingMethod: skip closures handled by callable rule#356
Conversation
…able rule Extract shared ImmediatelyInvokedCallableHelper to eliminate duplication between the callable and yielding rules. The yielding rule now only reports closures that are @param-immediately-invoked-callable or directly invoked, since non-immediately-invoked and standalone closures are already covered by ForbidCheckedExceptionInCallableRule. Closes #346 Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative implementation for #349 (closes #346) — extracts a shared
ImmediatelyInvokedCallableHelperinstead of duplicating the reflection/argument analysis logic.ImmediatelyInvokedCallableHelper— shared service encapsulating reflection resolution,ArgumentsNormalizerdispatch,isImmediatelyInvokedCallablecheck, andisCallableExpressiondetectionForbidCheckedExceptionInCallableRule— removed 5 duplicated methods (~116 lines),whitelistAllowedCallablesnow delegates to the helperForbidCheckedExceptionInYieldingMethodRule— only reports yielding closures that are@param-immediately-invoked-callableor directly invoked; non-immediately-invoked and standalone closures are left toForbidCheckedExceptionInCallableRuleWhy not just merge #349?
PR #349 solves the problem correctly but duplicates ~80 lines of reflection/argument analysis logic from the callable rule. This creates a maintenance burden — any PHPStan API change (like the fiber processing change in #340) would require identical fixes in both rules.
Improvements over #349
getParameterIndexsupport for named args whenArgumentsNormalizerfallback kicks inNullsafeMethodCallhandling inisCallableExpressionTest plan
Co-Authored-By: Claude Code